Bug 4307 - user reported build-perl-modules.pl bug
: user reported build-perl-modules.pl bug
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tools
: 6.5.0
: PC Linux (other)
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-05 16:32 UTC by Kevin Pearsall
Modified: 2008-12-18 11:11 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2006-10-05 16:32:31 UTC
It looks like a bug was introduced in slimserver's 
Bin/build-perl-modules.pl script in revision 8759. The script stores the 
text "lwp", or the full path of curl or wget (from File::Which) in 
$downloadUsing. The script later compares $downloadUsing to 'curl', which 
will almost never match since $downloadUsing contains the full path of curl 
or wget, not just 'curl' or 'wget'.

Below is a quick change I used with success on my system, but there are 
probably more robust solutions.

The change that introduced the problem can be seen here:

<http://svn.slimdevices.com/trunk/server/Bin/build-perl-modules.pl?rev=8759&r1=8712&r2=8759><
/a>

-Michael


--- Bin/build-perl-modules.pl.orig	2006-10-04 21:29:15.000000000 -0700
+++ Bin/build-perl-modules.pl	2006-10-04 18:00:41.000000000 -0700
@@ -198,7 +198,7 @@

			LWP::Simple::getstore("$SOURCE/$package?view=auto", 
$package);

-		} elsif ($downloadUsing eq 'curl') {
+		} elsif ($downloadUsing =~ /curl$/) {

			`$downloadUsing --silent -o $package 
$SOURCE/$package?view=auto`;
Comment 1 Dan Sully 2006-10-11 09:27:56 UTC
Fixed in change 10291