Bug 429 - Show 'inactive' players.
: Show 'inactive' players.
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: All All
: P3 enhancement with 3 votes (vote)
: Future
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-07-01 20:10 UTC by Daryle Tilroe
Modified: 2013-05-17 18:51 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daryle Tilroe 2004-07-01 20:10:15 UTC
Often it would be much more convienient to see all the players in the web
interface instead of having to go edit the prefs file.  Particularly useful with
multiple squeezeboxes and softsqueeze locations that are not always connected.
Comment 1 Blackketter Dean 2004-07-02 07:14:28 UTC
Hi Daryle.  I'm a little confused by this.  The current behavior is to only display the players that the 
server has heard from since it was last started.  This prevents the accumulation of players that are no 
longer in use (a particular problem with software-based players.)   Are you suggesting that every player 
that's ever connected to the server be shown all the time?
Comment 2 Daryle Tilroe 2004-07-02 07:24:12 UTC
Actually yes, because otherwise they are hidden and either cluttering up the
prefs file when they should just be deleted ('forgotten') or inaccessible when I
would like to make changes or tweak settings.   IMHO the accumulation you refer
to is actually made worse by hiding them.  I know several times I have gone into
the prefs file to manually clean up or change settings for hidden players (for
example makeng some changes to my work softsqueezes, while I was thinking of it,
from home).  Right now without manually hitting the file a user could end up
with dozens of stale player entries in the prefs file after some months of
fooling around with multiple hard and soft players.  I know I would like to
always see a list of all my players whether or not they have been turned on
since the the last time the server has run.
Comment 3 Blackketter Dean 2004-07-02 07:29:36 UTC
I'm still confused.  Are you saying that the prefs should be purged?  Or that the inactive players should 
be displayed?  My feeling is now that for the average user that the current behavior is right.  Even the 
accumulation of hundreds of players in the prefs file isn't a substantial burden and showing players that 
are long gone probably isn't a good idea.  

What might make sense is to hide players that haven't been heard from for a particular amount of time 
(1 day or so?) Rather than relying on the server's process lifecycle. How does that sound?

Comment 4 Daryle Tilroe 2004-07-02 07:47:26 UTC
> I'm still confused.  Are you saying that the prefs should be purged?
> Or that the inactive players should be displayed?

The latter; "inactive players should be displayed". This gives the user the
opportunity to purge them or alter settings from the web interface.

> My feeling is now that for the average user that the current
> behavior is right.  Even the accumulation of hundreds of players
> in the prefs file isn't a substantial burden and showing players
> that are long gone probably isn't a good idea.  

Thats sort of my point that they would not accumulate if the user saw them and
could delete them.  I think that having old stuff accumulate out of sight is a
bad idea.  A loose analogy is the windows menu feature that hides little used
selections; except this is even worse in that there is no way to see the stuff
short of editing the text file.

> What might make sense is to hide players that haven't been
> heard from for a particular amount of time (1 day or so?)
> Rather than relying on the server's process lifecycle. How
> does that sound?

That length of time will never be right for everyone.  Since you don't think the
average user will be interested in keeping the prefs clean or altering settings
on less used players perhaps the best solution would be some short of server
preference: e.g. "Show all Players".
Comment 5 KDF 2004-07-02 18:09:45 UTC
I expect this will, in fact, break a great deal of the current architecture.  If
the server allows access to non-existent player settings, we'd have crashes all
over the place due to calls to non-existent clients. 
Comment 6 Blackketter Dean 2004-07-02 19:10:38 UTC
We could get around that issue by creating instances of players at startup time that have been heard 
from in a while.  Essentially, we'd decouple the creation of player objects from the initial connection if 
they'd been heard from before.  This isn't a big issue right now, but it's something to think about.  It's 
one of the last "features" that depends on the startup time of the server for behavior.

Comment 7 Daryle Tilroe 2004-07-02 19:59:46 UTC
> I expect this will, in fact, break a great deal of the
> current architecture.  If the server allows access to
> non-existent player settings, we'd have crashes all over
> the place due to calls to non-existent clients. 

This confuses me quite a bit.  How is showing all players
different from showing disconnected ones that happen to have
been in contact since the last restart?  I have often changed
settings on disconnected players via the web interface.  AFAIK
it only alters the prefs file and then the next time they
are in communication again the settings are applied.  What
am I missing?
Comment 8 KDF 2004-07-03 23:49:51 UTC
the difference is, that players in the prefs file may not have been discovered.
 players that you have disconnected since starting the server have been
discovered and the server has a client object established.  the architecture
would have to change such that a client object then exists for existing players
and non-existing players.  to me, this leads to a mess.
Comment 9 Daryle Tilroe 2004-07-04 00:25:13 UTC
> the difference is, that players in the prefs file may not
> have been discovered. players that you have disconnected
> since starting the server have been discovered and the
> server has a client object established.  the architecture

This is where my lack of knowledge of the terminology and
operating specifics of slimserver is a real handicap.  I presume
that when a client ids itself initially to the server it
creates some sort of memory resident 'client object' that is
then populated by any matching prefs entries, then manipulated
as required (with corresponding prefs changes).  Is this
roughly correct?

> would have to change such that a client object then exists
> for existing players and non-existing players.  to me, this
> leads to a mess.

I guess the kludge would be to sniff the prefs file for all
players and acivated client objects in advance.  You say this
leads to a mess; by this do you mean just potientially having
a lot of memory resident objects if you never house cleaned?
Comment 10 KDF 2004-07-18 17:09:14 UTC
yes, the client object is created via the discovery process.  Thus, without a
client, you'd have to recover the client object from somewhere else.  the mess
comes from adding code to handle this, as well as handling responses for
non-existent clients such that the server is aware is a dead client, but doesn't
cause a crash or waste resources (ie, starting a transcoded playback to
non-existent clients).

perhaps the player list could show all clients found in the prefs file, but
block all functions for inactive ones, save for 'forget player'.  my personal
opinion is that this is a lot of rework for little gain.  I just can't see the
real use of this.  I've been using hte same prefs file since day one and with
all its old player data, I'll agree its annoying to find things when editing
manually, but I never need to do that for regular use, nor do I find the file
too large to keep around, especially compared with 87Gigs of music library.

it mainly depends on what functions you feel are required for inactive players.
Comment 11 Daryle Tilroe 2004-08-06 06:40:31 UTC
Notice you change to enhancement, fine with me.  Although I did notice that
someone else on the list noticed the amount of old player 'crud' in the prefs
file.  It was also suggested that it needed to be cleaned up or deleted to get
an upgrade problem to go away.  Not that this would necessarily fix the latter.

To answer you previous note:  I would say all features would be the best.  When
I notice this annoyance the most is upgrading and testing new features.  For
example I'm sitting my my PC/server in the basement and decide to try out the
new scroll delay/speed features.  I download and install the new slimserver. 
Then I have to run upstairs to turn on the Squeezebox, back down to tweak the
setting, and back up to test it out.  Just a little pain, but good exercise :-).
 Perhaps also a good excuse to by a wireless laptop.
Comment 12 Blackketter Dean 2005-06-07 11:10:00 UTC
Moving bugs that won't be immediately fixed in 6.1 release. Please review and update if this is an error 
or if this bug has already been fixed.  Thanks.
Comment 13 Andy Grundman 2006-08-05 14:22:28 UTC
This will be needed for SN integration, so I will take it.
Comment 14 Andy Grundman 2006-08-05 14:23:09 UTC
*** Bug 3791 has been marked as a duplicate of this bug. ***
Comment 15 Daryle Tilroe 2006-08-05 15:32:48 UTC
Yeaaahhh!!!  Two years and my enhancement is finally getting some respect. ;-)
Comment 16 Jim McAtee 2006-08-05 17:51:47 UTC
As far as the web UI is concerned... I think it would be best to not show these inactive players directly on the home page under 'Settings'.  For one, it will potentially clutter up that page, particularly for anyone who has a lot of inactive software players.  Secondly, this is currently the best way to see at a glance which players are actively connected.  Instead, provide a link to 'Inactive Players' and then present a list of all players on another page, with some kind of indication of which are active and which are inactive.
Comment 17 Andy Grundman 2006-08-05 17:54:16 UTC
This will certainly need some discussion, but I was considering something like:

Server Settings
Player Settings for Living Room
Player Settings for Bedroom (on SqueezeNetwork)
Player Settings for Kitchen (offline)

etc.
Comment 18 KDF 2006-08-06 17:35:16 UTC
you may want to consider a cleanup routine.  For those who have dynamic ip's and streaming clients, you could end up with many defunct players.  it might be good to have a setting for the number of days to automatically forget.

when combined with the enhancement for default new player config, this would make a really good manager for this type of application
Comment 19 Chris Owens 2008-12-18 11:49:28 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.