Bug 4280 - random mix plugin doesn't gracefully handle several unplayable tracks in a row
: random mix plugin doesn't gracefully handle several unplayable tracks in a row
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.4.0
: PC Windows XP
: P4 minor (vote)
: 7.4.0
Assigned To: Alan Young
: new_streaming
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-02 21:45 UTC by eric irrgang
Modified: 2009-01-22 09:04 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eric irrgang 2006-10-02 21:45:29 UTC
I saw a similar bug report that I can't find now.  Sorry.

In the 9-29-06 build of 6.5.x, if the Random Mix plugin was in random album mode and added an album of unplayable tracks (Apple DRM) and "repeat all" was on the player would jump to the first track in the playlist but report that it was playing the first track in the unplayable album and continue to misreport the current track though incrementing each time.

In today's build (10130) the playlist will update as the player tries the first two unplayable tracks and will then loop back to playing the first track while reporting it is playing the third unplayable track.  After that, behavior seems to be the same as above.

In pre-6.5 releases, the player would attempt each unplayable track in turn and the random mix plugin would append another album to the playlist and the player would continue from there.  There was also a default behavior of not including unplayable tracks in the library or some such thing that seemed like a good idea.
Comment 1 KDF 2006-10-02 21:58:59 UTC
re bug 3696
Comment 2 eric irrgang 2006-10-02 22:12:57 UTC
whether or not "Add new items when old ones finish" sometimes affects behavior, but there seem to be other forces at work.  I'm not sure I'm encountering merely a single discreet bug.
Comment 3 Andy Grundman 2006-10-03 06:49:31 UTC
If you're getting DRM tracks in your database, that shouldn't happen and could be another bug.

The fix for bug 3696 makes the plugin restart if the last track in the list fails.  I think that should work for this case too, but I'll do some more testing.
Comment 4 Chris Owens 2006-10-03 11:46:17 UTC
I'm assigning this on to you Andy since you made the mistake of taking an interest. :) Feel free as always to assign it back to me, or on to someone else.
Comment 5 Andy Grundman 2006-10-03 18:30:48 UTC
I can't reproduce this bug.  Any amount of unplayable tracks are skipped over and the next valid track is played.  If the last item in the random mix is unplayable, the entire random mix is restarted with fresh tracks.  I don't think the value of the repeat setting has any effect when in random mode.

If you can reproduce this I'd like to see a --d_plugins --d_source log from the latest nightly 6.5.1 build.
Comment 6 Chris Owens 2006-10-05 09:04:58 UTC
I spent a little time yesterday trying to reproduce this, and I wasn't able to.  The workaround is fairly easy, too (figure out which tracks are the bad ones and remove them from the playlist).  I'm setting this to fix for 7.0 and assigning it back to me to look at after 6.5.1 is in the can.
Comment 7 Michael Herger 2007-12-21 06:50:54 UTC
Chris - any update on this one?
Comment 8 Blackketter Dean 2007-12-29 07:16:11 UTC
Apparently fixed.  Please reopen if you can reproduce in 7.0.  Thanks.
Comment 9 Chris Owens 2008-03-07 09:03:53 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.
Comment 10 Chris Owens 2008-06-13 11:57:13 UTC
Andy had to back this change out due to bug 7702.  The right fix for this bug will hopefully be possible after the 7.2 new streaming work.
Comment 11 Alan Young 2009-01-22 09:04:59 UTC
If you really have that many unplayable tracks in your library then just increase the random play window.