Bug 424 – songinfo download link crashes server if no client found

Bug 424 - songinfo download link crashes server if no client found

Summary:

songinfo download link crashes server if no client found

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	5.x or older
Platform:	PC All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-06-30 10:35 UTC by KDF
Modified:	2008-12-18 11:53 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
check client before using accessors (631 bytes, patch) 2004-06-30 11:14 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2004-06-30 10:35:51 UTC

run the server without a client, try to access songinfo via browser and it comes
up with the following error:

Can't call method "model" on an undefined value at
D:/slim/server/Slim/Web/HTTP.pm line 1010.

Comment 1 KDF 2004-06-30 11:14:13 UTC

Created attachment 56 [details]
check client before using accessors

This little patch seems to avoid the problem.  it is probably the only way to
really avoid calling an accessor on a client when a client doesn't exist.

Comment 2 Blackketter Dean 2004-06-30 12:14:10 UTC

go for it!

Comment 3 Chris Owens 2006-06-16 14:40:24 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.

Comment 4 Chris Owens 2008-12-18 11:53:02 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.