Bug 4207 – Less than 2 title formats in server settings breaks player title format strings

Bug 4207 - Less than 2 title formats in server settings breaks player title format strings

Summary:

Less than 2 title formats in server settings breaks player title format strings

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	6.5.0
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-09-24 03:27 UTC by Nigel Birch
Modified:	2008-12-18 11:11 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nigel Birch 2006-09-24 03:27:40 UTC

This is with SlimServer Version: 6.5.0 - 9916 - Windows XP - EN - cp1252, Perl Version: 5.8.7 MSWin32-x86-multi-thread & MySQL Version: 5.0.22-community-nt.

To reproduce:

1. From the web interface, go to Server Setting > Formatting > Title Format.
2. Remove all title formating strings, except for the first one.  Click change.
3. Go to Player Settings > Basic Settings > Title Format.
4. The Formats drop down list is empty.  The player UI just shows the track title.

Adding a second title format string under server settings (even the same as the first one) fixes player UI.  I think this is a bug.  Shouldn't server settings allow just a single title format, thereby forcing all players to use the same title format with no choice?

Thanks.

Comment 1 KDF 2006-09-24 15:52:22 UTC

problem is due to this bit of code in setup:

	# hack around a race condition at startup
	if (!Slim::Utils::Prefs::getArrayMax($pref)) {
		return;
	};

unfortunately, while this was required in a previous version, this problem can be fixed by removing these lines as long as the more recent prefs handling negates the problems once caused by the 'race condition' mentioned.  For the record, this bit of code was added back at change 682

Comment 2 Chris Owens 2006-09-26 09:26:27 UTC

cc'ing Dan

Comment 3 Dan Sully 2006-09-26 10:52:23 UTC

What was the race condition, exactly?

Comment 4 KDF 2006-09-26 11:46:39 UTC

to be honest, I can't recall.  I THINK it used to come up blank in server settings because of the prefs not being fully populated in time.  However, that was over 2 years ago (change 682).  I can't seem to get it to fail currently. Probably ok to get rid of it, but we'd want to keep an eye on the results.

Comment 5 Chris Owens 2006-10-04 11:05:52 UTC

Better sooner than later so we can get it into some nightlies before we ship.

Comment 6 KDF 2006-10-04 11:28:49 UTC

ok, I'll have it in tonight.

Comment 7 KDF 2006-10-04 18:31:18 UTC

in trunk at change 10201, 6.5.1 at change 10202
please reopen if there are any problems.

Comment 8 Nigel Birch 2006-10-05 10:13:05 UTC

Works great for me.  Thanks.