Bug 4190 – xmlbrowser transition problem

Bug 4190 - xmlbrowser transition problem

Summary:

xmlbrowser transition problem

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.3.1
Platform:	PC Windows (legacy)

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-09-22 13:03 UTC by KDF
Modified:	2008-12-18 11:11 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
proposed solution (800 bytes, patch) 2006-09-23 06:37 UTC, Adrian Smith	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2006-09-22 13:03:37 UTC

entering xmlbrowser mode seems to show a momentary empty display during transition.  problem appears to be in teh block mode handling.  This affects some other browse modes as well.  Correction of the issue is possible by bypassing teh update in Block::endMode but this has some known side-effects with a couple plugins.  


problem also in SN and 6.5.0

Comment 1 KDF 2006-09-22 13:06:04 UTC

cc'ing michael as this relates to the Album Review/Biography plugins.

Comment 2 Adrian Smith 2006-09-23 06:37:21 UTC

Created attachment 1577 [details]
proposed solution

Proposing to solve with attached patch which avoids block mode updating the screen unless block mode continues for more than 0.2 sec.  Longer term I want to rewrite block mode to be more integrated with the display code.

Michael, I suspect this will impact your plugins don't work - will discuss with you directly.

Comment 3 Adrian Smith 2006-09-24 03:59:05 UTC

Patch added - trunk: 10010, 6.5: 10011

I believe the problem is now fixed - will follow up with Machael re his plugins.

Comment 4 Michael Herger 2006-09-24 12:53:05 UTC

Adrian, I can confirm that my plugins are broken :-). Everything's working if I remove the block mode. I will see what consequences this will have. If it's only lacking the animation I will live with it.

Comment 5 Michael Herger 2006-09-24 13:44:44 UTC

What would be the consequence of simply resetting the block.updatedscreen to 0 again (in my plugin only):

$client->block({
	'line' => [	
		$client->string('PLUGIN_ALBUMREVIEW'), 
		$client->string('PLUGIN_ALBUMREVIEW_COLLECTINGINFO')
	]
});
$client->modeParam('block.updatedscreen', 0);

Comment 6 Adrian Smith 2006-09-26 11:10:59 UTC

I believe this can now be closed.  I've followed up with Michael and he has found a way for his plugins to work with the patched server code.

Comment 7 KDF 2006-09-26 11:54:42 UTC

righty-ho, let's call this one fixed :)