Bug 4148 - Background visualizer should only be displayed when on Now Playing or if music is playing
: Background visualizer should only be displayed when on Now Playing or if musi...
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Web UI
: Prod
: Macintosh Other
: P2 major (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-19 06:44 UTC by Blackketter Dean
Modified: 2008-12-15 12:16 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2006-09-19 06:44:51 UTC
Latest trunk nightly has it shown all the time, even when off.
Comment 1 Blackketter Dean 2006-09-19 06:45:26 UTC
This is in last night's nightly  in trunk.  Not sure if it's in 6.5 yet.
Comment 2 Blackketter Dean 2006-09-19 06:58:10 UTC
I only see this in trunk, not on 6.5.
Comment 3 Adrian Smith 2006-09-19 10:46:46 UTC
Which players is this seen for?  Transporter or SB2 as well?
Comment 4 Blackketter Dean 2006-09-19 11:24:08 UTC
Subject: Re:  Background visualizer should only be displayed when on Now Playing or if music is playing

Saw this on my SB3 this morning.

Comment 5 Adrian Smith 2006-09-19 11:45:22 UTC
Its probably due to Mosers changes to Slim::Buttons::Playlist.  Assuming we are not planning to merge this to 6.5 I will look at later.
Comment 6 Blackketter Dean 2006-09-19 12:11:51 UTC
Subject: Re:  Background visualizer should only be displayed when on Now Playing or if music is playing

Thanks!

Comment 7 Blackketter Dean 2006-09-20 12:27:22 UTC
this is a current issue on SqueezeNetwork.  let's get that fix in there first, as that's shipping now.
Comment 8 Adrian Smith 2006-09-20 13:35:44 UTC
OK this is definately due to the change to Slim::Buttons::Playlist::showingNowPlaying in trunk - essentially this can't be used as it always returns true now!!!

Dean - can you confirm when you want the visualizer to show, is it:
playmode eq play || in 'playlist' mode || in 'screensaver' mode

Or do you want to only show it if we are showing Now Playing in playlist mode (which is now harder as that logic has gone away)?

Perhaps it could be just when playing?
Comment 9 Blackketter Dean 2006-09-20 13:49:43 UTC
Subject: Re:  Background visualizer should only be displayed when on Now Playing or if music is playing

Hey Triode.  The background/sidebar visualizer should be shown when  
playing or when on the current song in the playlist.  The latter is  
so you can hit now playing and rotate through the views without music  
having to be playing.

The screensaver visualizer overrides this whenever a screensaver is  
up that uses the visualizer.

Make sense?

Comment 10 Robert Moser II 2006-09-22 21:51:36 UTC
Dean, how can you tell if a screensaver is using the visualizer?
Comment 11 Blackketter Dean 2006-09-23 08:00:16 UTC
Subject: Re:  Background visualizer should only be displayed when on Now Playing or if music is playing


On Sep 22, 2006, at 9:51 PM, Slim Devices Bugzilla wrote:
> Dean, how can you tell if a screensaver is using the visualizer?
You shouldn't have to.  The screensaver just specifies it as part of  
its display.

This all worked before just fine...

Comment 12 Adrian Smith 2006-09-24 05:26:56 UTC
I think 10012 fixes this for trunk (based on patch send to dev list) - consider this for SN?
Comment 13 Blackketter Dean 2006-09-24 11:27:46 UTC
Looks good in trunk, let's get it into SN
Comment 14 Andy Grundman 2006-09-24 11:58:29 UTC
Updated SN to include this fix.
Comment 15 James Richardson 2008-12-15 12:16:01 UTC
This bug has been fixed in the latest release of SqueezeNetwork!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.