Bugzilla – Bug 411
multiple artists tags break on details page
Last modified: 2008-12-18 11:53:34 UTC
When using the multple artists capability (which is excellent!) you cannot correctly follow the "artist" link on any of the track detail pages. The artist link is not split, so in this particular case I have a tag which is "Brian Ferry;Roxy Music", this works fine on the artist list, you see both independently, however when you look at a track you see "Brian Ferry;Roxy Music" and then clicking on that fails, since this is actaully two different artists. I suspect the link will need to be split into multiple different ones to keep consistency.
Here is a sample implementation of a fix ... I'm sure it's not the best way to do it ... and it doesn't use the configured "split" characters, but I'm sure someone can fix it up. *** songinfo.html Tue Jun 29 14:58:40 2004 --- songinfo.html.orig Tue Jun 29 14:12:04 2004 *************** *** 36,58 **** <td class="nowrap">[% "TITLE" | string %][% "COLON" | string %]</td> <td> [% title | html %] </td> </tr> ! [% IF artist %] ! [% PERL %] ! # ! # Prepare the artist list... ! # ! my $artist = $stash->get( "artist" ); ! my @list = split( /;/, $artist ); ! $stash->set( "artistlist", \@list ); ! $stash->set( "lastartist", $list[$#list] ); ! [% END %] <tr> <td class="nowrap"> [% "ARTIST" | string %][% "COLON" | string %]</td> ! <td> ! [% FOREACH aindex = artistlist %] ! <a href="browseid3.html?genre=*&artist=[% aindex | uri %]&player=[% player | uri %]" target="browser">[% aindex | html %]</a> ! [% IF lastartist != aindex %] / [% END %] ! [% END %] </td> </tr> [% END %] [% IF composer %] --- 36,45 ---- <td class="nowrap">[% "TITLE" | string %][% "COLON" | string %]</td> <td> [% title | html %] </td> </tr> ! [% IF artist %] <tr> <td class="nowrap"> [% "ARTIST" | string %][% "COLON" | string %]</td> ! <td> <a href="browseid3.html?genre=*&artist=[% artist | uri %]&player=[% player | uri %]" target="browser">[% artist | html %]</a> </td> </tr> [% END %] [% IF composer %]
Vidur, I expect that your database work will point towards a different (and more elegant solution, no?)
Dan says fixed for 6.0. Please confirm and reopen if not fully addressed.
Routine bug db maintenance; removing old versions which cause confusion. I apologize for the inconvenience.