Bug 4104 – link to FAQ under help shouldn't put ?player=[MACADDY] at end of url

Bug 4104 - link to FAQ under help shouldn't put ?player=[MACADDY] at end of url

Summary:

link to FAQ under help shouldn't put ?player=[MACADDY] at end of url

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5b2
Platform:	All All

Importance:	P5 trivial (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-09-13 12:10 UTC by Kevin Pearsall
Modified:	2008-12-18 11:12 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
remove player param for external links (3.87 KB, patch) 2006-09-13 21:31 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin Pearsall 2006-09-13 12:10:05 UTC

This is trivial, but who knows, maybe it might cause some problems with phpMyFAQ at some point.

Comment 1 KDF 2006-09-13 21:31:08 UTC

Created attachment 1533 [details]
remove player param for external links

removes the query for the faq link and blocks the player param from any external help link

Comment 2 Blackketter Dean 2006-09-16 16:23:39 UTC

Thanks, KDF. Just a note: those two if clauses could be simplified into an if / else, right?

Comment 3 KDF 2006-09-16 16:38:33 UTC

yup, should work as if/else/end.  I was lazy so was just using cut and pastte for the diff :)

Comment 4 KDF 2006-09-16 20:42:59 UTC

fixed at change 9790, trunk only since this is for 7.0

Comment 5 Chris Owens 2008-03-07 09:03:48 UTC

This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.