Bugzilla – Bug 4063
Manual search play controls for album results don't work
Last modified: 2008-09-15 14:39:24 UTC
This is with r9474 (not got the other details since copy works but paste has stopped working. Windows, eh?) To reproduce: 1. Use the Default skin to search (Search Music). 2. Type in an artist, e.g. Killers and press Search or hit enter. 3. Play/Add won't work, like bug 4059, for albums. All Songs for albums, Albums and Songs work fine. 4. Clear the search text box. 5. Type in an artist again, e.g. Killers but this time let the auto-search thing happen. 4. Play/Add now works for albums. Or at least I think that's whats going on. Thanks.
Sorry. Step 3 should be: 3. Play/Add won't work, like bug 4059, for artists. All Songs for artists, albums and songs work fine.
this time it's contributor.role that should not be in the url. affects all skins using cmdwrappers.
problem change was added at change 8784, in order to allow TRACKARTIST role to show up in search. Something needs to either handle or delete the contributor.role for the play command. error and backtrace as follows: 2006-09-07 10:53:37.4801 Request: Command [ba:43:80:ae:96:cd->playlist loadtracks] cb+ (Bad dispatch!) 2006-09-07 10:53:37.4805 Param: [_what] = [cookies=HASH(0x8efd9d8)&contributor.role=ALL&content=&path=status_header.html&player=ba:43:80:ae:96:cd&url_query=command=playlist&subc ommand=loadtracks&contributor.id=122&contributor.role=ALL&player=ba%3A43%3A80%3Aae%3A96%3Acd&host=localhost:9000&contributor.id=122&subcommand=loadtracks&webroot=/&command=playlist ] 2006-09-07 10:53:38.5576 DBD::mysql::st execute failed: Unknown column 'contributor.role' in 'where clause' at D:\slim\server\CPAN/DBIx/Class/Storage/DBI.pm line 743. 2006-09-07 10:53:38.5581 ERROR: Error executing 'SELECT me.id, me.url, me.content_type, me.title, me.titlesort, me.titlesearch, me.album, me.tracknum, me.timestamp, me.filesize, me .disc, me.thumb, me.remote, me.audio, me.audio_size, me.audio_offset, me.year, me.secs, me.cover, me.vbr_scale, me.bitrate, me.samplerate, me.samplesize, me.channels, me.block_alig nment, me.endian, me.bpm, me.tagversion, me.drm, me.moodlogic_id, me.moodlogic_mixable, me.musicmagic_mixable, me.musicbrainz_id, me.playcount, me.lastplayed, me.lossless, me.lyric s, me.rating, me.replay_gain, me.replay_peak FROM tracks me JOIN albums album ON ( album.id = me.album ) LEFT JOIN contributor_track contributorTracks ON ( contributorTracks.track = me.id ) JOIN contributors contributor ON ( contributor.id = contributorTracks.contributor ) WHERE ( contributor.id = ? AND contributor.role = ? ) GROUP BY me.id ORDER BY concat (album.titlesort, '0'), me.disc, me.tracknum, concat(me.titlesort, '0')': DBD::mysql::st execute failed: Unknown column 'contributor.role' in 'where clause' at D:\slim\server\CPAN/ DBIx/Class/Storage/DBI.pm line 743. 2006-09-07 10:53:38.5587 ERROR: Backtrace follows: 2006-09-07 10:53:38.5592 Backtrace: frame 0: Slim::Schema::Storage::throw_exception (D:\slim\server\CPAN/DBIx/Class/Storage/DBI.pm line 745) frame 1: DBIx::Class::Storage::DBI::_execute (D:\slim\server\CPAN/DBIx/Class/Storage/DBI.pm line 798) frame 2: DBIx::Class::Storage::DBI::_select (D:\slim\server\CPAN/DBIx/Class/Storage/DBI/Cursor.pm line 118) frame 3: DBIx::Class::Storage::DBI::Cursor::all (D:\slim\server\CPAN/DBIx/Class/ResultSet.pm line 921) frame 4: DBIx::Class::ResultSet::all (D:\slim\server/Slim/Control/Commands.pm line 2205) frame 5: Slim::Control::Commands::_playlistXtracksCommand_parseSearchTerms (D:\slim\server/Slim/Control/Commands.pm line 1038) frame 6: Slim::Control::Commands::playlistXtracksCommand (D:\slim\server/Slim/Control/Request.pm line 1463) frame 7: (eval) (D:\slim\server/Slim/Control/Request.pm line 1463) frame 8: Slim::Control::Request::execute (D:\slim\server/Slim/Control/Request.pm line 752) frame 9: Slim::Control::Request::executeRequest (D:\slim\server/Slim/Web/HTTP.pm line 667) frame 10: Slim::Web::HTTP::processURL (D:\slim\server/Slim/Web/HTTP.pm line 517) frame 11: Slim::Web::HTTP::processHTTP (D:\slim\server/Slim/Networking/Select.pm line 238) frame 12: Slim::Networking::Select::select (D:\slim\server\slimserver.pl line 485) frame 13: main::idle (D:\slim\server\slimserver.pl line 438) frame 14: main::main (D:\slim\server\slimserver.pl line 1037)
also, I suppose if regular search was modified to handle TRACKARTIST by adding contributor.role=ALL, perhaps liveSearch needs this as well?
Fixed in change 9544
Works for me - thanks.