Bugzilla – Bug 4053
SB2 shows "Squeezebox2/v3" when turning on in single line mode
Last modified: 2009-09-08 09:28:06 UTC
This is with SlimServer v6.5b1 - 9424 (Windows XP - EN - cp1252, Perl Version: v5.8.7 MSWin32-x86-multi-thread, MySQL Version: 5.0.22-community-nt). Another small might-might-not-be-a-bug one. When turning on a Squeezebox2, in double line mode (standard font) it displays "WELCOME TO SQUEEZEBOX" and "Free your music". However, when in single line mode (full font), it displays "Squeezebox2/v3". Given that SB2/SB3 are called just "Squeezebox" elsewhere, I think it'd make more sense to display just "Squeezebox". To reproduce: 1. With a Squeezebox2, turn player on. 2. Set size to single line (full font). 3. Turn player off. 4. Turn player on. "Squeezebox2/v3" is displayed. Thanks.
This is by design, Slim::Player::Player::power(), line 431 of Player\Player.pm: $oneline ? $client->string($client->model) : $client->string('FREE_YOUR_MUSIC') ] if the setting for size is to show only one line, the player model is shown. for playermodel SQUEEZEBOX2, this string becomes "Squeezebox2/v3" for WELCOME_TO_SQUEEZEBOX2, this gives a string of "Welcome to Squeezebox" given that all other WELCOME_TO_(playermodel) strings have specific references to the player model, the WELCOME_TO_SQUEEZEBOX2 string could probably change to "Welcome to Squeezebox2/v3" basically a more generallised scope of bug 3993.
Thanks, KDF. Yes, that makes sense either way. Perhaps I should have said that they're inconsistent, instead.
cc'ing Dean for comments.
Well "Squeezebox2/v3" doesn't mean anything and looks bad. I suggest that either we show the full welcome text (preferred) in the small font size or we just skip the message altogether. (accpetable)
Created attachment 1500 [details] two line welcome ok, here's the patch to make it a two-line welcome. I would personally prefer that to a blank screen. Although, it would go to the normal start display after powering on anyway. This uses the small fonts for each type of display.
Subject: Re: SB2 shows "Squeezebox2/v3" when turning on in single line mode Awesome, please commit.
Probably want to make the fonts 'standard' and 'medium' to match up with the default fonts for each the player types?
good point. I'll take care of it this evening. (not sure why I haven't been getting cc's on this one)
fixed in trunk at change 9515, 6.5 at change 9516
Thanks.