Bug 3995 - Support artwork for internet radio stream
: Support artwork for internet radio stream
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.5b1
: All All
: P2 enhancement with 1 vote (vote)
: Future
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-24 14:44 UTC by James Craig
Modified: 2007-09-30 13:16 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Diff for Track.pm changes (347 bytes, text/plain)
2006-09-02 00:33 UTC, James Craig
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2006-08-24 14:44:50 UTC
It would be nice if you could set artwork for internet radio stations.
At present you can set the thumb/cover for a track but they will never be displayed because of this code in Slim::Schema::Track

sub coverArt {
	my $self    = shift;
	my $artType = shift || 'cover';
	my $list    = shift || 0;

	# return with nothing if this isn't a file. 
	# We don't need to search on streams, for example.
	if (!$self->audio) {
		return undef;
	}
Comment 1 KDF 2006-08-24 14:50:23 UTC
little bit of a more positive spin :)
Comment 2 James Craig 2006-09-01 14:28:08 UTC
there are two levels on which I'd like this to work
1) supply local file as artwork
2) supply web address for artwork

I have a small patch for Track.pm which seems to get the 1st working - should I attach a diff file?
Not sure about the 2nd - I guess this might be a bit more complicated...
Comment 3 Chris Owens 2006-09-01 14:30:36 UTC
cc'ing Andy because he might be interested
Comment 4 James Craig 2006-09-02 00:33:48 UTC
Created attachment 1493 [details]
Diff for Track.pm changes

I moved the point at which the artwork check stops for 'non audio' files to after the first check, which picks up a local file. (The stop is still required as otherwise stream urls would be scanned for artwort if none is supplied in the db).
With this patch and a tweak to LastFM plugin I successfully displayed a local file as artwork in Web interface.
Comment 5 James Craig 2007-09-30 13:16:12 UTC
Artwork for internet radio streams works pretty well in 7.0 if you implement the getMetadataFor() method in your ProtocolHandler - this doesn't seem necessary any more.