Bug 3951 – Web settings headers should be consistent

Bug 3951 - Web settings headers should be consistent

Summary:

Web settings headers should be consistent

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5b1
Platform:	Macintosh Other

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-08-17 08:19 UTC by Blackketter Dean
Modified:	2008-09-15 14:39 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
patch to css (408 bytes, patch) 2006-08-17 12:23 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2006-08-17 08:19:02 UTC

In the web ui, Default skin., the settings sometimes have their titles on a grey background and sometimes not.  They should all appear with the grey background.

Comment 1 KDF 2006-08-17 10:32:26 UTC

Group Descriptions have grey backgrounds, Pref Descriptions do not.  
The use of Groups headings and pref headings is inconsistent, especially so with Plugins.  

css could be used to make the pref headers the same as group headers by adding ".settingSection .prefHead" to the style that also applies to .settingSection .groupHead

Comment 2 KDF 2006-08-17 10:36:31 UTC

sadly...having just tried this, it makes other settings look odd.  Those having a group AND pre header end up with a doubled grey box.  It's probably still an improvement overall.

Comment 3 KDF 2006-08-17 12:23:55 UTC

Created attachment 1435 [details]
patch to css

for review.  give that a shot and see if it meets your desires.

Comment 4 Chris Owens 2006-08-17 15:21:25 UTC

reassigning to dean since his is the next step!

Comment 5 Blackketter Dean 2006-08-17 22:09:20 UTC

Subject: Re:  Web settings headers should be consistent

Thanks, KDF.  I tried it and tweaked it to fix the layout a bit.   
Will commit with a couple of other minor fixes.

Comment 6 Chris Owens 2006-08-18 12:38:29 UTC

ping dean

Comment 7 KDF 2006-08-28 16:57:39 UTC

haven't seen this go through yet, did I miss it?

Comment 8 Dan Sully 2006-09-02 17:13:17 UTC

Dean?

Comment 9 Chris Owens 2006-09-08 11:42:49 UTC

ping Dean

Comment 10 KDF 2006-09-11 12:39:54 UTC

so...fixed at change 9551 and a few scattered tweaks between 9551 and 9594