Bug 3941 - show Front Panel ir option in settings only for transporter
: show Front Panel ir option in settings only for transporter
Status: CLOSED FIXED
Product: SB Transporter
Classification: Unclassified
Component: SB Server
: unspecified
: Macintosh Other
: P2 enhancement (vote)
: Future
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-16 20:48 UTC by KDF
Modified: 2008-12-15 13:04 UTC (History)
0 users

See Also:
Category: ---


Attachments
drop front panel as an irfile when the client isn't transporter (2.37 KB, patch)
2006-08-16 20:50 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2006-08-16 20:48:50 UTC
Front Panel doesn't really apply as an ir option for any client aside from Transporter, so it would make sense to leave that one out unless the player is a transporter.
Comment 1 KDF 2006-08-16 20:50:05 UTC
Created attachment 1432 [details]
drop front panel as an irfile when the client isn't transporter

adds client as an arg for irfiles, so that the client type can be used to drop the front panel ir file from non-transporter clients in player settings.
Comment 2 KDF 2006-08-16 20:53:26 UTC
Mentioned this to Dean already.  He wasnt sure if this was needed for 6.5.  I would have changed this to undef, but as 6.5 is the default, I'll leave it at that and you guys can decide when is the right time.
Comment 3 Chris Owens 2006-08-17 12:15:58 UTC
Assigning it to Dean for a ruling then.

I don't really have a strong opinion about whether or not we should add this prior to 6.5.

It is the 'right' thing to do, but having a well-labeled option that clearly doesn't apply doesn't seem likely to irritate SB3/2/1/slimp3 users either.
Comment 4 KDF 2006-08-17 12:50:50 UTC
I agree.  I believe the usual phrasing is something along the lines of "but my wife finds it incredibly annoying" ;)
Comment 5 Blackketter Dean 2006-08-17 15:10:04 UTC
Patch looks reasonable, but it's not a showstopper for this release.  Feel free to apply, or hold off if you have something else to do.  Thanks!
Comment 6 KDF 2006-08-17 23:06:22 UTC
fixed at change 9033
Comment 7 James Richardson 2008-12-15 13:04:35 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.