Bug 3935 - new css based default skin does not scale well in some places
: new css based default skin does not scale well in some places
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.5b2
: Other All
: P2 major (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-16 15:10 UTC by Kevin Pearsall
Modified: 2009-09-08 09:11 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
overlapping strings (6.56 KB, image/png)
2006-08-18 02:43 UTC, Michael Herger
Details
screen capture (81.80 KB, image/pjpeg)
2006-08-18 17:14 UTC, Jim McAtee
Details
patch to Default index.html with frames (1.37 KB, patch)
2006-09-02 17:39 UTC, Jim McAtee
Details | Diff
give this a shot (1.04 KB, patch)
2006-09-13 13:00 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2006-08-16 15:10:31 UTC
mostly:
- in the music player section on the top right, volume overlaps with things on the right, etc.
- affects low res screens (640x480, 800x600)
Comment 1 Ross Levine 2006-08-17 18:21:59 UTC
Could we get a screen shot of this? I'm not seeing it. 
Comment 2 Michael Herger 2006-08-18 02:43:25 UTC
Created attachment 1443 [details]
overlapping strings

Switch to German and you don't even need a small screen - 1024x768 is small enough...
Comment 3 Chris Owens 2006-08-18 12:34:07 UTC
This is a CSS issue.  KDF do you have any thoughts?
Comment 4 KDF 2006-08-18 12:50:45 UTC
Same thoughts as always....css really stinks when things arent perfect.  Initially I did what I could to make this happen as infrequently as possible (at least for english and 1024x768 :), but I dont know of any way to adjust sizing depending on the number of characters used.  I'm not sure of any way we can arrange layouts that work in every language without some serious time committment. Even if we reformat all of the font sizing to use percentages, this won't help for extra characters and I believe that the major downside to using % instead of pixels is that browsers vary even more widely in how they handle it.  With IE7 coming up, and its already famous buggering of the css spec, this is going to get a lot worse. Any nibbles on that web designer job posting??
Comment 5 Jim McAtee 2006-08-18 17:14:20 UTC
Created attachment 1445 [details]
screen capture

The way I've gotten around this problem is to introduce resizable left/right panes in the Default skin.  If the player controls overlap for the given window size and keep you from using them, you just drag the divider to make the right-hand pane wider.  That's probably the reason why the same issue isn't a problem in a skin like Fishbone.

The resizable panes are also much nicer when using the album gallery views.
Comment 6 KDF 2006-08-18 18:03:05 UTC
That could indeed be useful.  
Comment 7 Chris Owens 2006-08-28 10:24:17 UTC
see also bug 4008
Comment 8 KDF 2006-08-29 23:28:56 UTC
another Dean call.  The solution here can range from Jim's (best bang for the buck) through to a complete css rewrite with percentage-based sizing (which given the trouble I experienced just getting the damn blocks to even stay inside the frame, is a LOT of work at the risk of not actually achieving the desired result across platforms)
Comment 9 Andy Connors 2006-08-30 07:40:05 UTC
I have a comment regarding overlapping text also.  This is in the "Dark" skin in 6.5.  It's fine in 6.3.1.  It happens when I have a list of, say, ShoutCast internet radio stations in the left pane.  In this case, there is the text of the radio station name on the left of the pane and "Add" and "Play" buttons on the right of the pane.  I use Mozilla Firefox, with the fonts enlarged by pressing "Ctrl+" twice.  Resolution is 1024x768.  If I take the pane divider and drag it to the left in 6.3.1, making the left pane narrower, the radio station text and the "Add" and "Play" buttons are confined to two different columns.  The text will wrap on the left, staying in its own column and preventing overlap.  In 6.5, the "Add" and "Play" buttons are replaced with text, which is fine.  However, when I drag the pane divider to the left in 6.5, the radio station text no longer wraps.  It just overlaps into the "Add" and "Play" text.
Comment 10 Andy Connors 2006-08-30 11:28:43 UTC
Correction to previous comment:  When dragging the pane divider, the text in the left pane *does* wrap, but not until some overlap occurs.  So there's a discrepancy between where it's wrapping, and where the "Play" and "Add" text begins.
Comment 11 Dan Sully 2006-09-02 16:56:24 UTC
Dean - what are your thoughts here?

Jim - do you have a patch?

Thanks
Comment 12 Jim McAtee 2006-09-02 17:39:15 UTC
Created attachment 1497 [details]
patch to Default index.html with frames
Comment 13 Chris Owens 2006-09-07 13:34:56 UTC
Per Dean, putting this one off until 7.0
Comment 14 Dan Sully 2006-09-08 10:29:33 UTC
*** Bug 4008 has been marked as a duplicate of this bug. ***
Comment 15 Kevin Pearsall 2006-09-13 12:20:15 UTC
I'd like to request a re-evaluation of the priority of this issue.  There could be a lot of users out there using really old 800x600 laptops with pcmcia wireless cards as remote controls, and this looks hideous...
Comment 16 KDF 2006-09-13 13:00:25 UTC
Created attachment 1532 [details]
give this a shot

this reduces the space between volume digits.  it seems to fit better even at 800x600. what does everyone think?
Comment 17 Kevin Pearsall 2006-09-13 13:46:46 UTC
Subject: Re:  new css based default skin does not scale well in some places

Looks pretty good to me...
On Sep 13, 2006, at 1:00 PM, Slim Devices Bugzilla wrote:

> https://bugs-archive.lyrion.org/show_bug.cgi?id=3935
>
>
>
>
>
> ------- Comment #16 from slim-mail@deane-freeman.com  2006-09-13  
> 13:00 -------
> Created an attachment (id=1532)
>  --> (https://bugs-archive.lyrion.org/attachment.cgi?id=1532&action=view)
> give this a shot
>
> this reduces the space between volume digits.  it seems to fit  
> better even at
> 800x600. what does everyone think?
>
>
>
>
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.

Comment 18 Blackketter Dean 2006-09-13 14:03:31 UTC
Subject: Re:  new css based default skin does not scale well in some places

I like this solution.

In fact, what about just removing the padding-right and padding-left  
lines altogether?

I tried that and it looks fine at 800x600 in ie, firefox and safari.

Comment 19 KDF 2006-09-13 14:15:46 UTC
I went with 1px simply because it would balance a bit for those high-res cases.  purely selfish ;)
Comment 20 Dan Sully 2006-09-13 14:59:50 UTC
Fixed in change 9664
Comment 21 Chris Owens 2008-03-07 09:03:47 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.