Bug 393 - %20 encoded spaces visible when adding Album
: %20 encoded spaces visible when adding Album
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 5.x or older
: Other RedHat Linux
: P2 minor (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-06-20 12:02 UTC by Chris Harris
Modified: 2008-12-18 11:54 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Harris 2004-06-20 12:02:19 UTC
Using the latest nightly with the Slimserver running on Fedora Core 2. Music is
shared from subfolders of /var/share/Audio/

If you click 'Add' when you're displaying an Album name from a search, the 
screen changes to an 'Adding to Playlist' screen for a second or two. At 
this point the Album name is displayed with %20's instead of spaces.

To replicate this bug:

Search Music ->
Search For Albums ->
A <Search>

Albums matching "A" (1 of x)
24 Carat Gold <Add>

Adding to end of playlist:
24%20Carat%20Gold
Comment 1 Blackketter Dean 2004-06-20 12:29:27 UTC
Ah, got it.  Here's a patch:

Index: Slim/Buttons/BrowseID3.pm
===============================================================
====
RCS file: /home/cvs/cvsroot/slim/server/Slim/Buttons/BrowseID3.pm,v
retrieving revision 1.15
diff -r1.15 BrowseID3.pm
178,179c178,179
<               my $line1;
<               my $line2;
---
>               my ($line1, $line2) = lines($client);
> 
198,203d197
<               if (defined($genre) && defined($artist) && defined($album)) {
<                       $line2 = Slim::Music::Info::standardTitle($client, $currentItem);
<               } else {
<                       $line2 = $currentItem;
<               }
< 

I've marked this bug for 5.2, but I want Vidur to take a look at it first before I commit.
Comment 2 Blackketter Dean 2004-06-21 14:35:58 UTC
fixed for next nightly build
Comment 3 Chris Owens 2007-05-24 15:54:11 UTC
This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.
Comment 4 Chris Owens 2008-12-18 11:54:50 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.