Bug 3914 - 'Play other songs in album or directory' broken
: 'Play other songs in album or directory' broken
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.5b1
: PC All
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-11 10:59 UTC by Patrick Dixon
Modified: 2009-06-15 15:27 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
full diff (1.30 KB, patch)
2006-08-11 20:12 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Dixon 2006-08-11 10:59:25 UTC
CC3.2 6.5b1 r8926

With this preference set in Server Settings/Behaviour, selecting a track to play using the Player UI plays that track only and doesn't add the whole album to the Playlist.

ie the preference seems to be ignored.
Comment 1 Chris Owens 2006-08-11 11:09:51 UTC
I also see this behavior.
Comment 2 KDF 2006-08-11 16:05:36 UTC
Slim::Buttons::BrowseDB.pm, line 192 needs to change to:
if ($levels[$level-1] =~ /^(?:playlist|album)$/ && grep { /playlist|album\.id/ } keys %{$findCriteria}) {
Comment 3 KDF 2006-08-11 20:12:56 UTC
Created attachment 1417 [details]
full diff

diff for above with changelog entry.  getting a bit silly if you ask me.   changelog entries no longer really represent what has been fixed since last release since they include stuff that is merely broken since last week..etc etc.  however, it's there anyway.  make it look like more work is getting done at least :)
Comment 4 KDF 2006-08-11 20:13:29 UTC
patch attached.  can commit if that's the right thing.
Comment 5 Patrick Dixon 2006-08-12 10:51:08 UTC
Works for me.
Comment 6 Kolbj�rn Halvorsen 2006-08-17 16:24:02 UTC
I see the same problem.
Running SlimServer Version: 6.5b1 - 8996 - Debian - EN - iso-8859-1   on Ubuntu 6.06
(Behaviour was ok when I ran 6.3.1 on Fedora 4)
client is SB3, FW59.

I find this new behaviour very inconvenient and annoying.
Comment 7 KDF 2006-08-17 20:54:30 UTC
thanks for the input.  we're waiting on word from dan before committing the patch mentioned above, which does work.  It first has to be verified that it doesn't cause any other problems.

If you cannot handle some inconsistency, please stay away from the beta builds.
Comment 8 KDF 2006-08-18 11:43:31 UTC
*** Bug 3966 has been marked as a duplicate of this bug. ***
Comment 9 KDF 2006-08-18 11:51:31 UTC
Dan,

any comment on the attached diff?  should me.id be kept alongside album.id instead?
Comment 10 KDF 2006-08-22 19:50:44 UTC
fixed in change 9111.  reopen if any problems emerge.
Comment 11 mark 2007-07-30 17:04:28 UTC
This is still a problem for me in 6.5.3, in the web interface with the 'play other songs....' pref checked, playing a song in an album just plays that one song. Hardware player behaves different/correct.
Comment 12 Anoop Mehta 2009-06-15 12:35:35 UTC
I have a customer that is noticing this behavior in 7.3.2 and in 7.3.3.
 
Re opening bug.
Comment 13 Anoop Mehta 2009-06-15 15:10:55 UTC
closing this bug as I was mistaken.