Bug 3877 - Volume control display only appears very briefly when AlienBBC stream connecting
: Volume control display only appears very briefly when AlienBBC stream connecting
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.5b1
: PC All
: P2 minor (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-06 11:46 UTC by Patrick Dixon
Modified: 2006-08-14 15:56 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
possible solution (3.04 KB, patch)
2006-08-08 16:16 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Dixon 2006-08-06 11:46:30 UTC
If while you are waiting for a connection to a BBC stream, you press the volume control on the Player remote, you see the volume momentarily displayed on the Player display before the display flicks back to the now connecting message - but it's shown so briefly that you can't see what the volume control setting is.

It's as if the 'show briefly' is set to about a tenth of a second.

Acording to Triode this is common to all streams.

See this thread for discussion:-
http://forums.slimdevices.com/showthread.php?t=26170
Comment 1 Adrian Smith 2006-08-06 13:20:51 UTC
Probably want to make volume pass block to showBriefly - I'll look at this..
Comment 2 Adrian Smith 2006-08-06 13:35:59 UTC
OK can't handle this with current display code [block on volume means it doesn't update]

Will think about this....  One option is to store a name with showBriefly so the calling function can query whether it is the owner of a current showBriefly.
Comment 3 Adrian Smith 2006-08-08 16:16:55 UTC
Created attachment 1404 [details]
possible solution

Andy, Patrick - does this help.  It allows the caller of showBriefly to name itself so another potential caller can check to see if they own the text currently being displayed.
Comment 4 Patrick Dixon 2006-08-11 10:52:12 UTC
Adrian - will I need an update to AlienBBC to test this?
Comment 5 Adrian Smith 2006-08-11 10:53:42 UTC
No the "bug" is in the server...  If you can test and prove it fixes I would propose to get it in 6.5. 
Comment 6 Patrick Dixon 2006-08-11 11:17:20 UTC
Selecting an AlienBBC stream crashes slimserver v8926 with the following logfile :-

[root@music slimserver]# cat /tmp/slimserver.log
2006-08-11 19:13:44.1540 "my" variable %nameHash masks earlier declaration in same scope at /usr/local/trunk/server/Plugins/SortNames/Plugin.pm line 222.
2006-08-11 19:14:59.7354 ERROR: Path isn't a file URL: http://www.bbc.co.uk/fivelive/live/surestream.rpm

Can't use an undefined value as a symbol reference at /usr/local/trunk/server/Slim/Formats/Playlists.pm line 111.
[root@music slimserver]#
Comment 7 Adrian Smith 2006-08-11 11:22:18 UTC
Not sure how this patch could crash the server with that message!

Could you retry with the server started from the command line - does it work for other streams.  If so it is probably another problem crashing the server..
Comment 8 Patrick Dixon 2006-08-11 11:22:33 UTC
Actually AlienBBC seems to be broken in trunk at the moment ... r8931 too
Comment 9 Adrian Smith 2006-08-11 11:36:35 UTC
Yep - server no longer likes playing urls via execute playlist play commands.....!
Comment 10 Patrick Dixon 2006-08-12 07:03:18 UTC
The patch solves the problem for me.

Thanks Adrian.
Comment 11 Adrian Smith 2006-08-12 07:30:38 UTC
OK - should be in svn r8944.
Comment 12 Chris Owens 2006-08-14 12:59:33 UTC
Shall we mark this 'fixed' then, or are there additional aspects that need work?
Comment 13 Adrian Smith 2006-08-14 13:02:10 UTC
I consider it fixed.