Ben, it this tooltip issue Nigel describes by-design or is it a bug?

this only affected the cover thumb that was in the upper-left corner of each page.

should be fixed with 8/8 daily build.

With r8856, I'm still seeing this with question mark thumbs in the middle of the page and at the bottom right.  I've not got any at the top left (I'm sure I had before - perhaps the pagination/sort order changed between the nightly builds) so I can't confirm that case.

Ben, is Nigel's remaining issue still part of this bug?

With today's nightly (r9056), I'm not seeing any artwork at all (in any skin) after a fresh install and wipe/re-scan.  So, I can't test to see if the behaviour is still the same.

Not sure that was about, the but a clear and re-scan fixed the no artwork problem.  With r9056 I'm still seeing the behaviour in my 2006-08-08 comment.

Nigel,

So tooltips are mostly working now, but you're still not seeing them for albums in specific locations on the screen?  The middle and the bottom right?

Yes, the tooltips work for albums that have album artork.  However, for those that don't have album artwork (so show the question mark place holder) the tooltips don't show.

Ben says he fixed the case where the question mark album was at the top-left, but I don't have that appear at the top-left (so I can't confirm).  I do have question mark albums in the middle of the page on the left-hand side (half-way down) that are still not showing tooltips.  This is on r9165.

Nigel, what browser are you using? I get mouseover album/artist information for both albums with cover art and without cover art. This works fine in both Firefox and Opera.

Moving this to FIXED/WORKSFORME. If you feel that is in error, please reopen as needed.

I'm testing with Firefox v1.5.0.6, Opera v9.0.1 on Windows XP Service Pack 2.  I've completely removed SlimServer and installed r9195 and I still see the same (browser cached cleared too).  I'll email you the page source from Firefox - the HTML for albums without artwork is different to those that have it.

source for the page shows:

<img src = "/Nokia770/html/images/cover.png" border = '0' width="100" style='STYLE="border: 1px solid white"'></a>

so, there will be no tooltips for a page using this source. the cover.png image is called up when there is no artwork detected (as opposed to being unable to retrieve the expected artwork, which returns the question mark image data for teh thumb.jpg request)

I can repro, so I'll dig further

thanks, KDF. What I'm seeing on my slimserver for covers with no artwork is this:

<img STYLE="border: 1px solid black" src="/music/5743/thumb_100x100_f_000000.jpg" alt="8 Track Stomp by Chickasaw Mud Puppies" title="8 Track Stomp by Chickasaw Mud Puppies"></a>

In skin-speak, I'm returning true from [% IF item.coverThumb %], while Nigel and yourself are not. That I don't understand, but the fix here is probably making it so there is still and alt and or title attribute to the img tag in cases where item.coverThumb returns false. I'm having trouble finding where that is... EN/cmdwrappers?

ok, looks like the problem is in browsedb_artwork.html:

		[% IF item.coverThumb %]
			<a [% PROCESS browseDbItemHRef %]>
			[% PROCESS thumbnailItemImg height="100" width="100" style='STYLE="border: 1px solid black"' %]</a>
		[% ELSE %]
			<a [% PROCESS browseDbItemHRef %]>
			<img src = "[% webroot %]html/images/cover.png" border = '0' width="100" style='STYLE="border: 1px solid white"'></a>
		[% END %]

in the ELSE case, there is no title or alt.  

consider replacing the cover.png href with dummyItemImg from hreftemplate, like so:
[% PROCESS dummyItemImg height="100" width="100" style='STYLE="border: 1px solid black"' %]</a>


That seems to do the trick for me.

I checked it in. Thanks as always for the assistance, KDF.

Sorry. :)

With r9232 (after un-install, delete, re-install, clear cache) I'm still seeing the problem.  The source shows:

<img src = "/Nokia770/html/images/cover.png" border = '0' width="100" style='STYLE="border: 1px solid white"'></a>

Any other info I can gather?

generated from the same portion of the IF clause, my img tag has alt and title attributes.
<img STYLE="border: 1px solid black" src="/html/images/cover.png" height="100" alt="Antics by Interpol"  title="Antics by Interpol">

I'm thinking this may have something to do with differences in server settings between our slimservers. Will investigate further.

Nigel, can you confirm that lines 6-12 of HTML/Nokia770/browsedb_artwork.html look like this, particularly line 11 and the [% PROCESS dummyItemImg... part?

                [% IF item.coverThumb %]
                        <a [% PROCESS browseDbItemHRef %]>
                        [% PROCESS thumbnailItemImg height="100" width="100" style='STYLE="border: 1px solid black"' %]</a>
                [% ELSE %]
                        <a [% PROCESS browseDbItemHRef %]>
                        [% PROCESS dummyItemImg height="100" width="100" style='STYLE="border: 1px solid black"' %]</a>
                [% END %]

dummyItemImg is generated from EN/hreftemplate:
[%# img tag for album thumbnail in browse artwork context %]
[% BLOCK dummyItemImg -%]
 [% artistlist = ''; IF item.artist; itemobj=item.itemobj; artistlist = PROCESS artistsAsText.html; END %]
 [%- "<img $style src=\"/html/images/cover.png\" height=\"";height or 100;"\"" %]
 [%-    " alt=\"";item.item | html; artistlist ; IF item.year; " ($item.year)"; END; "\"" %]
 [%- " title=\"";item.item | html; artistlist ; IF item.year; " ($item.year)"; END; "\">" -%]
[%- END %]

If you didn't have artist or album attributes stored for a particular album/track, dummyItemImg should still product empty quote attributes for alt and title (alt = "" title = ""), but your previous post to this bug doesn't support this.

No, my line 11 is:

<img src = "[% webroot %]html/images/cover.png" border = '0' width="100" style='STYLE="border: 1px solid white"'></a>

Replacing that with your line fixes it.  Thanks.

SVN shows the same:

http://svn.slimdevices.com/branches/6.5/server/HTML/Nokia770/browsedb_artwork.html?rev=9178&view=markup

It looks like your change was added at r9213 to trunk but after 6.5 was branched.  I'm on the 6.5 nightly, not the trunk.  So it needs copying from trunk to 6.5.  Would that be it?

bingo, that's it.

I'm not very good at keeping up with the dev forum, so I hadn't realized the 6.5 branch had happened.

KDF and/or slimdevs, what's the approved procedure for checking things back to the 6.5 branch? Do I have permission to checkin on that branch?

cache?

you probably have permission.   check out a copy of trunk, and check out a copy of 6.5
(svn co https://svn.slimdevices.com/repos/slim/branches/6.5/server)

if you make a diff from your trunk changes, then test the trunk changes, you can apply the patch to 6.5 and commit.
6.5 should only get tested fixes.  NO new features.

can't get the svn commit to work on 6.5. it just returns me to a prompt with no error. Checkin doesn't happen...

bklaas@mediumspicy /usr/local/slimserver6.5/HTML/Nokia770 $ svn commit -m "bugfix for bug 3870" browsedb_artwork.html
bklaas@mediumspicy /usr/local/slimserver6.5/HTML/Nokia770 $ 

probably have to email dan on svn issues.
I'll merge the change when I get home tonight if it isn't resolved.  it will make it into tomorrow's build for sure.

did the checkout for 6.5 work?
do you get anything with 'svn status', or 'svn diff' ?

checkout worked, but both svn diff and svn status give no response, same as the svn commit did.

ok, silly question.  did you make the change to browse_artwork after the checkout?

silly questions are intended for silly people, of which I count myself a charter member. I *swear* I made the change, but sure enough I didn't. Many apologies for the wild goose chase.

Change is made and checked into 6.5.

Looks good.  Ben/KDF - thanks.