Bugzilla – Bug 3840
Gaps in gallery view on Pocket IE - handheld skin
Last modified: 2006-08-17 13:49:26 UTC
Using the handheld skin on my PDA (Dell Axim X50), thumbnails in gallery view are inconsistent in size. The problem doesn't occur in IE6 or Firefox on my desktop PC; only Pocket IE. If I go to New Music in Gallery view mode, I get two thumbnails to a row with Play/Add buttons underneath. However, some of the thumbnails appear to be one or two pixels too large in height, and thus no thumbnail is displayed underneath that. The Play/Add buttons for the larger image don't line up with the Play/Add buttons for the adjacent album. I notice that for artwork that is wider than the height, the artwork is scaled such that the width aligns with other images, but as a result the Play/Add buttons are immediately under the image (the image isn't centred in the space). On desktop PC, the Play/Add buttons are horizontally aligned no matter how tall the thumnails are.
This is still on my list, but my Axim is being borrowed. I need to retrieve it.
Philip, could you please add a screenshot of this. I still don't have a PocketPC ("only" a Zaurus running Opera ;-)).
Created attachment 1420 [details] New Music in Gallery view mode on Dell Axim - Handheld skin
I also notice now that the List/Gallery view icon is positioned a bit clumsily. /New Music <icon> Pages 1 2 | Items 1 to 50 of 100". I don't recall it looking like this last time I used it. I think the icon used to be aligned to the right of the screen. I just checked what it looks like on desktop PC via Firefox - it is indeed aligned to the right, but takes up horizontal space across the line. eg: /New Music <icon... ...icon> Pages 1 2 | Items 1 to 50 of 100". It would be nicer if it is possible to lay it out like: /New Music <icon... Pages 1 2 | Items 1 to 50 of 100". ...icon> Or alternatively (if easier): <icon... /New Music ...icon> Pages 1 2 | Items 1 to 50 of 100"
I think we're exploring PocketIE's limitations in CSS capabilities... I haven't found out yet what causes the empty spaces. The same page (using the Handheld skin) does look ok in FF and IE6? > I also notice now that the List/Gallery view icon is positioned a bit clumsily. I wouldn't call it clumsy in all cases, but it can be :-). What revision are you on? I recently changed the layout a bit. It was something like: / New Music <icon> Pages 1 2 | [sort order selector] Items 1 to 50 of 100 I wanted it to be: / New Music [sort order selector] <icon> Pages 1 2 3 4 | Items 1 to 50 of 100 To be wrapped if needed: / New Music [sort order selector] <icon> Pages 1 2 3 4 | Items 1 to 50 of 100 This is imho working find in desktop browsers and Opera on my Zaurus. I don't have PocketIE to test with (screenshots are always welcome :-)). > /New Music > <icon> > Pages 1 2 | Items 1 to 50 of 100". > I don't recall it looking like this last time I used it. > I think the icon used to be aligned to the right of the screen. Hmm... does PIE support the CSS 'float'? Before that change I used a table to do the layout. But this made the page bar wrap in a much too small column at the left (see first of my drawings). I therefore tried to have it laid out without using tables, using CSS. But this is asking for trouble :-(. Could you try changing the following style in Handheld/slimserver.css: .viewSelect { white-space: nowrap; float: right; } Remove the "nowrap" thingy: .viewSelect { float: right; } Does this improve the layout? > It would be nicer if it is possible to lay it out like: > > /New Music <icon... > Pages 1 2 | Items 1 to 50 of 100". ...icon> You're asking too much of PocketIE, really. It's not up to date concerning CSS. Maybe we'll have to use a different icon for Handheld as it's simply too big for the small screens. "float"ing it doesn't seem to be working: either in the wrong place or generating additional empty space (interestingly I don't seem either of these problems in Opera...). I'll have to come up with another idea :-/ Is gallery mode feasible on a handheld? Let's remove it ;-)
Yes, there are no gaps in album artwork in Firefox/IE6 - handheld skin looks fine on these browsers. In IE6 and Firefox, the view mode icon is right-aligned, but still leaves a gap on the left. This is not so bad, as obviously the desktop resolution is better - there's more screen to play with. In Pocket IE, view mode icon is left-aligned. I will attach screenshots. I am currently on SVN 8951. I tried changing the css file to remove the "whitespace: no-wrap" but it made no difference to pocket IE. I think a smaller icon is a good idea. Alternatively perhaps stick the icon as an in-line image on the left and allow two lines of text to wrap around it.
Created attachment 1422 [details] Screenshot of view button in IE6/Firefox
Created attachment 1423 [details] screenshot of View button layout in Pocket IE
Created attachment 1424 [details] the tables are back... I put the tables back in place, but have the second row span across the two columns. Is this working better for you?
Still got the gaps in the artwork. The icon is now on the right, but there's still wasted space between "/New Music" and "Pages: 1 2". It's Better though ;)
> Still got the gaps in the artwork. Oh, I didn't care about them, yet... I'm still trying to get rid of the messy header. > The icon is now on the right, but there's still wasted space between "/New > Music" and "Pages: 1 2". Is the icon higher than the sort selector when you browse by album?
> Still got the gaps in the artwork. Are the albums in the gap actually missing or did they just move to the right or something?
Created attachment 1425 [details] make a floating DIV instead of the TABLE Phil, a first try at fixing the gap issue. Any better?
Comment on attachment 1425 [details] make a floating DIV instead of the TABLE Please save as cmdwrappers_Handheld
Created attachment 1426 [details] Improved header, smaller icons, possible fix for the gap This archive contains the following potential fixes/enhancements: - smaller icon - removed "sort by" - cleaner header in eg. browse by album - wrap the table in a div The archive's content goes into HTML as it contains a change to EN/galleryselect.html, too. Please give it a try.
Okay, just tried your latest patch. The smaller icon works much better, reducing the space between the two lines of text. In browse Albums, the drop-down sort order is aligned to the right of the icon, so this is good too. The drop-down itself is a little bigger, causing a little bit more space, but that probably can't be helped. In gallery view, all albums are displayed, but the artwork is now appearing all in one column, left-aligned. I am seeing quite a bit of vertical spacing between parts of the screen: 1. Above the Squeezebox logo main heading. 2. Above Home/Status/Playlist/Search. 3. Above "/ Albums" 4. Before the list of albums. I'll try to upload some pictures tomorrow morning - no time now (I should find some software for the PDA to take screenshots, rather than get the camera out!).
Created attachment 1427 [details] Browse albums in Pocket IE
Phil, I'll have a look at what's wrong with that white space. Shouldn't be there. Concerning the missing artwork: is it really missing or are the albums just moved one place?
Phil, one more question: the blank spaces you're seeing in the header. Didn't you have them with 6.3 or other earlier releases? That part's structure hasn't been changed for far more than a year?!? The only thing I can imagine is CSS. Could you rename Handheld/slimserver.css and refresh the page: do you see better results in the pageheader part?
I can't remember for sure about the white space, whether it was present on Pocket IE in previous releases. I don't think so, as I probably would be commented on it before. The white space problem is only an issue with Pocket IE. IE6 and Firefox look fine. All album artwork is present (no albums are missing), it's just not layed out correctly. Currently all in one left-aligned column.
> The white space problem is only an issue with Pocket IE. IE6 and Firefox look > fine. With a little luck I'll get my hands on a PocketPC very soon. This will considerably ease testing. I'll let you know if I find something better. > All album artwork is present (no albums are missing), it's just not layed out > correctly. > Currently all in one left-aligned column. "currently" is with my patch? Just replace the cmdwrappers_Handheld with its original to get back the intermittent gaps...
Got a PocketPC to test today - turned out to be _extremely_ helpful debugging (working around) the issues described here. I just checked in a few changes (revision 8988) which address the gap and the excessive white space issues. Phil, you might want to have a look at Microsoft's simple "Remote Display Control" to remotely control your PPC and take screenshots: http://www.microsoft.com/technet/prodtechnol/wce/downloads/ppctoys.mspx#ELD
Thanks for the tip on Microsoft's "Remote Display Control". The link you posted was for Windows CE, but I found a version for Windows Mobile 2003SE. The album gap problem is fixed. The whitespace issue is fixed too, except perhaps in gallery view mode. I can see extra whitespace above/below the album artwork. I expect the play/add buttons should be tucked up right under the album. I have found some other handheld skin problems, but not related to this bug. Would it be easier to mail you direct about them, or whack all other things I've spotted onto a new bug?
Created attachment 1433 [details] Screenshot of album artwork in gallery view mode Excessive spacing around artwork?
bug 3782? space, no space, how much space? pick one and lets please call a dead issue, dead.
> The album gap problem is fixed. The whitespace issue is fixed too, except > perhaps in gallery > view mode. I can see extra whitespace above/below the album artwork. I expect > the play/add buttons should be tucked up right under the album. So do I. But I haven't found a way to do it. Compared to how it was before we lose about the add/play buttons' height per page. With 240x320px we can still see four art covers, but the second row lacking the buttons. I thought this was an acceptable compromise (concentrating on removing the gaps). > I have found some other handheld skin problems, but not related to this bug. > Would it be > easier to mail you direct about them, or whack all other things I've spotted > onto a new bug? It's a good moment for me to work on this. Feel free to send stuff to me directly. Thanks! And please close this bug (I can't)
Bug 3782 was different. There was no spacing then, and images weren't centred. The current gallery view is better, but seems to have a lot more spacing top/bottom than left/right. There were other spacing issues reported on this bug, so I wondered if this one had been missed. If you look at the latest screenshot, the space between the window edge and the left edge of the leftmost thumbnail, is what I would expect around all sides of the thumbnails. [Perhaps a little bit more between play/add buttons and the next thumbnail to keep the buttons grouped with the right artwork].
Marking fixed per Michael Herger