Bug 3837 - Digital Input plugin should only appear on transporters
: Digital Input plugin should only appear on transporters
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.5b1
: Macintosh Other
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-28 21:30 UTC by Blackketter Dean
Modified: 2008-09-15 14:39 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
digial input in settings (2.29 KB, patch)
2006-07-31 13:59 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2006-07-28 21:30:37 UTC
 
Comment 1 KDF 2006-07-29 00:00:39 UTC
What about making it a setting item, which could then easily be pushed/popped from the player UI settings menu
Comment 2 Blackketter Dean 2006-07-29 00:03:57 UTC
Subject: Re:  Digital Input plugin should only appear on transporters

That would be fine.  In fact, preferred.

(Though it would be nice for plugins to be able to be added to  
settings, I was thinking that the Rescan plugin should probably  
appear in settings just tonight.)

Comment 3 KDF 2006-07-31 10:19:50 UTC
It could be done.  the addMenu feature does allow something, but we'd need to adjust the settings module to be more of a plugin itself,. adding to the home menu hash instead of being it's own fixed structure.  My only thought lately is that the server is including a lot of plugins that it confuses the line where plugins were more of a third party thing.  When users upgrade, they don't have that mindset to check plugins for incompatiblities, possibly because they think of them as being just part of the server.

My other idea for making the home menu an OPML navigable via the xmlbrowser would also make this kind of thing easier. I just have far less of an idea of how to write that, then I would about adding settings or refactoring the settings mode.
Comment 4 KDF 2006-07-31 12:25:45 UTC
I'm making a very simple INPUT.Select module, which expects a list of items, where only one in the list is selectable and shown with the checkbox overlay.  All functions are hard coded, with PLAY and ADD acting as actions to set the change.  

What I'm missing from fixing this specific issue is a way to read the current state.  From the plugin, it doesn't appear that there is one.  How do we know what the current setting is?
Comment 5 KDF 2006-07-31 13:59:38 UTC
Created attachment 1388 [details]
digial input in settings

adds core strings, player pref (w/ default), and a checkboxOverlay handled UI for Transporter.
Comment 6 Dan Sully 2006-08-01 12:10:05 UTC
Fixed in change 8756