Bug 382 - trying to download a file when there isn't a client connected can crash the server
: trying to download a file when there isn't a client connected can crash the s...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: All All
: P2 major (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-06-17 12:02 UTC by Blackketter Dean
Modified: 2008-12-18 11:54 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2004-06-17 12:02:47 UTC
run the server without having any clients connect, then browse to a song info page in the web interface 
and click on download.  this will cause the server to crash.  Here's a patch:

Index: Slim/Web/HTTP.pm
===============================================================
====
RCS file: /home/cvs/cvsroot/slim/server/Slim/Web/HTTP.pm,v
retrieving revision 1.109
diff -r1.109 HTTP.pm
999c999,1001
<       assert($client);
---
> 
>       # when we are streaming a file, we may not have a client, rather it might just be going to a web 
browser.
>       # assert($client);
1002a1005
> 
1007c1010
<       if (($client->model eq 'squeezebox') && defined($httpClient) &&
---
>       if ($client && ($client->model eq 'squeezebox') && defined($httpClient) &&
Comment 1 Chris Owens 2007-05-24 15:54:08 UTC
This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.
Comment 2 Chris Owens 2008-12-18 11:54:48 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.