Bugzilla – Bug 3812
playlist play command does not play m3u playlist
Last modified: 2008-09-15 14:39:24 UTC
Every evening I run a sequence of CLI commands from cron. These commands that work in 6.3.1 crash 6.5 version 8593. mixer volume 5 playlist shuffle 1 playlist play sleepytime (sleepytime is a sleepytime.m3u playlist in my playlists folder) I turned on a variey of debugging options and captured the error: 2006-07-24 15:23:50.1813 parsed 215 items in m3u playlist 2006-07-24 15:23:51.7022 ERROR: openSong: Error finding an object for [ARRAY(0xa802118)]! 2006-07-24 15:23:51.7090 Request: Callback disabled 2006-07-24 15:23:51.7119 Request: Command [00:04:20:05:60:8a->playlist play] from CLI (Done) 2006-07-24 15:23:51.7153 Param: [_item] = [/export/home/slim/playlists/sleepytime.m3u] I checked the docs for 6.5 to see if the playlist play command was still supported and it appears that it is.
I couldn't help but notice the similarities between this and bug 3786.
It's similar, but 3786 is related to genres. I expect this case is an array returned from a function that is expecting a reference to that array instead. The summary mentions a crash, so is there an actual note in the log for the actual crash of slimserver, or is the problem simply the open error on the array?
If I turn off all debugging flags to capture just the crash message I get this in the log: 2006-07-24 16:48:36.7670 scanPathOrURL: Finding valid files in: /export/home/slim/playlists/sleepytime.m3u 2006-07-24 16:48:36.7842 Found 1 files in /export/home/slim/playlists/sleepytime.m3u 2006-07-24 16:49:01.5763 ERROR: openSong: Error finding an object for [ARRAY(0xad8ce00)]!
Apologies. This was crashing slimserver in the 2006_07_22 build. It is *not* crashing v8593 (2006_07_24). It seems like something's been patched up since I got time to investigate more closely. However, there is still a bug: the playlist play command is not playing music. I've adjusted the summary and priority appropriately.
that error message alone would indicate that the server does remain running. Just to be sure we're chasing a bad url grab only, and not something that kills the server itself as well.
Slim/Control/Commads.pm line 926 can change to: push @{ Slim::Player::Playlist::playList($client) }, @{$foundItems->[0]}; and this fixes it. However, I think this indicates something isn't right from Scanner->scanPathOrURL, which changed in 8491 around this section of code.
The scanner code looks correct.. Fix commited as change 8660
just for my understanding... what is the purpose of the array of array refs then? in other words, what would we be using $founditems->[1...x] for?