Bug 3811 - Artwork from just 1st album displayed when tracks from multiple albums listed
: Artwork from just 1st album displayed when tracks from multiple albums listed
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: PC Fedora
: P4 minor (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-24 15:31 UTC by Richard Harnwell
Modified: 2009-01-29 09:47 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
Example (63.62 KB, image/jpeg)
2006-07-24 15:32 UTC, Richard Harnwell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Harnwell 2006-07-24 15:31:17 UTC
When listing songs other than by album (e.g. "all songs" or "by genre"), album art is shown for the first album in the list, but no others. For example, when I select "All Songs", I see the album art for "Beautiful South"/"0898", followed by all songs from that album, followed by all songs from "Carter USM"/"101 Damnations" etc. Only the "0898" album art is displayed.

This makes no sense. Either the art for every album should be displayed (before the first track for each new album), or no album art at all for such listings. I suggest that no album art at all should be displayed when listing songs from multiple albums.

This is obviously across all web browsers (I have checked with IE6, Firefox, Netscape).
Comment 1 Richard Harnwell 2006-07-24 15:32:31 UTC
Created attachment 1366 [details]
Example
Comment 2 Chris Owens 2006-07-24 15:57:05 UTC
You know, I'd swear I reproduced this last week, but now I don't see it.  I don't see any art until it is clear what album should be displayed.  

Has it been fixed along with some other bug recently?  What build are you using, Richard?
Comment 3 KDF 2006-07-24 16:14:09 UTC
Slim/Web/Pages/BroseDB.pm line 427.  It is possible, if the song list is from multiple albums to get artwork from the FIRST track in the list and only if that track has artwork linked with it.  To have this only appear when the track listing is from a single album, perhaps the following will do:
if ($level == $maxLevel && $levelName eq 'track' && defined $firstItem && defined $params->{'album.id'}) {

Things to test would be whether this works with multi-disk albums correctly, for both cases of the groupdisks pref\.
Comment 4 Jim McAtee 2006-07-24 19:28:08 UTC
Chris, try browsing by years in any year with more than one album.

kdf, your patch works.  In multi-disc albums the artwork still comes up under 'treat as single album'.  Haven't had a chance to rescan and test with the alternative pref.
Comment 5 KDF 2006-07-24 19:33:34 UTC
committed to trunk at change 8627. I'll mark as fixed and leave for Chris to verify/close, reopen if any problems come up.
Comment 6 Richard Harnwell 2006-07-25 12:15:58 UTC
I can confirm this is now fixed.

Cheers,

Richard
Comment 7 Jim McAtee 2006-07-25 13:11:37 UTC
Not quite fixed.  When browsing New Music I'm seeing no artwork on the track listing page of multi-disc albums.  The artwork is seen for the same albums if browsing any other mode or through search.
Comment 8 KDF 2006-07-25 13:26:54 UTC
ick....looks like it needs to check age.id too.  more ugly hard coding
Comment 9 KDF 2006-07-25 17:55:10 UTC
updated to change 8669