Bug 3803 – changing 'Maintain Client Playlists' setting crashes server

Bug 3803 - changing 'Maintain Client Playlists' setting crashes server

Summary:

changing 'Maintain Client Playlists' setting crashes server

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5b1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-22 11:24 UTC by Jim McAtee
Modified:	2008-09-15 14:39 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jim McAtee 2006-07-22 11:24:16 UTC

Trying to change 'Do not remember' to 'Remember'.  Here's what is logged (no timestamp):

Can't locate object method "client" via package "Slim::Player::Squeezebox2" at C:\Program Files\SlimServer\server/Slim/Player/Playlist.pm line 701.

Comment 1 KDF 2006-07-22 15:08:16 UTC

The cause of this is Utils::Prefs line 296, which makes a direct call to modifyPlaylistCallback, instead of using the dispatch.  Change 8580 avoids the crash, but further testing should be taken to make sure this is really doing the right thing that the command was intended for when players are synced. The change should issue the same call as before the callback was a request notify callback, but I can't really make sense of what it was intended to accomplish and cannot tell if it is really still required at all.

Comment 2 Dan Sully 2006-07-23 19:08:17 UTC

Yes - please let us know if this has been fixed.

Thanks

Comment 3 Jim McAtee 2006-07-23 19:36:01 UTC

It's no longer crashing.  I can't answer any of kdf's other concerns.

Comment 4 Dan Sully 2006-07-25 14:49:40 UTC

Yes, that code is doing the correct thing.

It saves the playlist for the master to the db (and to disk)