Bug 3800 - Multi-Discs albums will not show correcty in web interface
: Multi-Discs albums will not show correcty in web interface
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 6.5b1
: PC Other
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-22 06:27 UTC by Dominik M�hl
Modified: 2011-03-16 04:34 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
FLAC file #1 (4.39 KB, application/octet-stream)
2006-07-25 11:58 UTC, Dominik M�hl
Details
FLAC file #2 (4.54 KB, application/octet-stream)
2006-07-25 11:58 UTC, Dominik M�hl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik M�hl 2006-07-22 06:27:02 UTC
Hi,

I've just tried to get SlimServer 6.5 (rev 8573) to work on my Solaris 11 (nevada) machine.

After a few hours I thought it works and I happily rescanned my music collection. After that was done I saw a problem with multi disc albums. I was only seeing 1.<Trackname> instead of 1-1.<Trackname> in the Web interface.

So I tried to find the reason for that. After fiddling a little bit with the code and database I discovered that the DISC column in TRACKS is always NULL.

So I looked more deeply into the code and found the responsible piece of code in Schema.pm.

I've attached a diff of my changes. As I do not have a deep (or even a shallow) understanding of the SlimServer code this is obviously not a fix, but a workaround for me.

Perhaps some of the more enlightened can do a real bug fix or tell me what I've broken.

For more information please feel free to contact me.

Heres the diff (the debug flag got into it):

joey:/export/slimserver/program/6.5b1 $ svn diff Slim/Schema.pm
Index: Slim/Schema.pm
===================================================================
--- Slim/Schema.pm      (revision 8573)
+++ Slim/Schema.pm      (working copy)
@@ -29,7 +29,7 @@
 use Slim::Utils::Unicode;

 # Internal debug flags (need $::d_info for activation)
-my $_dump_tags = 0;                       # dump tags found/processed
+my $_dump_tags = 1;                       # dump tags found/processed
 my $_dump_postprocess_logic = 1;          # detailed report of post processing logic

 # Singleton objects for Unknowns
@@ -1342,7 +1342,7 @@
        # Push these back until we have a Track object.
        for my $tag (qw(
                COMMENT BAND COMPOSER CONDUCTOR GENRE ARTIST ARTISTSORT
-               PIC APIC ALBUM ALBUMSORT DISC DISCC ALBUMARTIST COMPILATION
+               PIC APIC ALBUM ALBUMSORT DISCC ALBUMARTIST COMPILATION
                REPLAYGAIN_ALBUM_PEAK REPLAYGAIN_ALBUM_GAIN
                MUSICBRAINZ_ARTIST_ID MUSICBRAINZ_ALBUM_ARTIST_ID
                MUSICBRAINZ_ALBUM_ID MUSICBRAINZ_ALBUM_TYPE MUSICBRAINZ_ALBUM_STATUS

Dominik
Comment 1 Dan Sully 2006-07-23 19:06:43 UTC
Dominik - I recently added that DISC item to fix another issue.

Could you upload the track that's causing this issue to the bug?

Thanks.
Comment 2 Jim McAtee 2006-07-24 19:17:56 UTC
At r8621 I see the exact same thing - all NULLs in the disc column in tracks.
Comment 3 Dominik M�hl 2006-07-25 05:41:25 UTC
Hi Dan,

I'm experiencing this with all my multi album tracks. But I will upload 1 or 2 of them when I'm back home this evening (should be late morning for you)

Dominik
Comment 4 Dominik M�hl 2006-07-25 11:58:20 UTC
Created attachment 1369 [details]
FLAC file #1
Comment 5 Dominik M�hl 2006-07-25 11:58:47 UTC
Created attachment 1370 [details]
FLAC file #2
Comment 6 Dominik M�hl 2006-07-25 12:01:38 UTC
I've attached two of my files. They are representative of my "tagging"-style for multi-disc albums. I used the strip-script from the forum to make them small :)

In these files I used DISCNUMBER but in some older files I used DISC. So far (till my 6.5 trip) both tags were interpreted and shown correctly.

Please tell me if there is anything else I can do to help.
Comment 7 Dan Sully 2006-07-25 14:47:48 UTC
Fixed in change 8661.

You'll need to wipe & rescan.