Bugzilla – Bug 3793
Can't play "All Songs" from search result page
Last modified: 2008-09-15 14:39:24 UTC
If you hit the "Search" button on the livesearch page, you'll get Play/Add All Songs" buttons. But these don't work. They only play/add one song (I think it's the first matching track). I first came across this problem in Handheld, as it doesn't support the live search. But it's reproducable in Default and Fishbone.
Sometimes for me it seems to add the LAST matching track, but it looks to me like there's a bug here.
looks like none of the All * controls are working currently. They descend properly, but don't seem to add songs. The command is using teh remoteURL format, so something in the detection has been lost.
on the search, it looks like there are limits on the search to keep the db hammering to a limit. The add all songs relies on the searchResults param, which doesn't seem to be getting stuffed properly. Perhaps a better way, and also preserving use of limits when needed, we could change searchResults to a query param and run the query when the command is given. parseListRef could check for a queryRef as well as listRef. This way, we run the full query only when needed.
Fixed in change 8758