Bug 3755 - Advanced search on genre crashes
: Advanced search on genre crashes
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.5b1
: PC Windows XP
: P2 major (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-14 12:00 UTC by Jim McAtee
Modified: 2008-09-15 14:39 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
slimserver log (4.25 KB, text/plain)
2006-07-14 12:01 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2006-07-14 12:00:15 UTC
See log file attachment.
Comment 1 Jim McAtee 2006-07-14 12:01:25 UTC
Created attachment 1343 [details]
slimserver log
Comment 2 Jim McAtee 2006-07-14 12:26:22 UTC
It's happening on more than just searching genre.  Also crashes searching file format.  Some single-criteria searches work without crashing, though.  I can still do track, album, artist, year searches.  But album+year crashes.
Comment 3 KDF 2006-07-14 12:39:13 UTC
Add after lnie 227 of Web/Pages/Search.pm:L

  if ($query{'genre'}) {
     push @joins, 'genreTracks';
  }

That seems to solve the genre crash.
Comment 4 KDF 2006-07-14 12:51:57 UTC
changing search.ct to search.content_type will fix the file types crashing.

Any others?  I'll commit the above fixes tonight.
Comment 5 Dan Sully 2006-07-14 12:59:21 UTC
Fixed in change 8438
Comment 6 KDF 2006-07-14 13:05:02 UTC
search.size needs to become search.filesize as well.

no more time to test, have to get back to day job stuff :)
Comment 7 KDF 2006-07-14 13:08:58 UTC
date modified results in "unknown column 'age'"

maybe search.age changed to search.timestamp?

These last two avoid a crash, but don't result in any track listing, however.
Comment 8 Jim McAtee 2006-07-14 13:10:05 UTC
Just checked in 8438.  Any date modified search, any file length search.  I mentioned the album+year crash already.
Comment 9 Dan Sully 2006-07-14 13:19:45 UTC
Ok - svn change 8440 should fix all this.
Comment 10 Jim McAtee 2006-07-14 19:37:16 UTC
Is it possible that these fixes could have affected the -other- web ui search?  Seems really messed up now.  I get links on the artist, album, and track names when the search auto-runs following characters entered in the text box.  But they all lead to a 404 error.  If I use the 'Search' button I get no links at all.  Seems that the play buttons may be playing all tracks in the library in some unknown order.  I'm at r8451.

Or I'll file a new bug...
Comment 11 Dan Sully 2006-07-14 19:39:38 UTC
The changes should not have affected the Basic Search.

Please file a new bug..
Comment 12 Dan Sully 2006-07-14 19:41:47 UTC
I take that back.. one of the other checkins did change this.

Can you up to svn 8452 and try again?
Comment 13 Jim McAtee 2006-07-14 19:48:31 UTC
That's got it.