Bug 3717 - Bug fix 3402 broke scanning of accented characters from iTunes
: Bug fix 3402 broke scanning of accented characters from iTunes
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: iTunes
: 6.5b1
: PC Debian Linux
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-08 12:03 UTC by PRJensen
Modified: 2008-09-15 14:39 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description PRJensen 2006-07-08 12:03:23 UTC
Seems like bug fix 3402 might be in the wrong place? With the code as is, artists that contain accented characters do not show up in the slimserver DB. However, if I comment out fix 3402, it works again.

I'm guessing that maybe the bug fix should be placed after the following code segment from Importer.pm?

		if ($] > 5.007 && $file && $Slim::Utils::Unicode::locale ne 'utf8') {

			eval { Encode::from_to($file, 'utf8', $Slim::Utils::Unicode::locale) };

			# If the user is using both iTunes & a music folder,
			# iTunes stores the url as encoded utf8 - but we want
			# it in the locale of the machine, so we won't get
			# duplicates.
			$url = Slim::Utils::Misc::fileURLFromPath($file);
		}

Phil
Comment 1 Dan Sully 2006-07-10 14:43:23 UTC
Fixed in change 8364