Bug 3704 – 'Browse' lists always start at top option..

Bug 3704 - 'Browse' lists always start at top option..

Summary:

'Browse' lists always start at top option..

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.3.0
Platform:	PC Linux (other)

Importance:	P2 normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-06 14:14 UTC by Marc Reichman
Modified:	2008-09-15 14:39 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Reichman 2006-07-06 14:14:40 UTC

The title pretty much says it all..
This is while using my SLiMP3 player with 6.3.0:

Anytime I choose 'Browse Music' -> 'Browse Artists' the list starts at the top, which is 'Various Artists'.
If I am in that tree and choosing around, and play a song, the next time I choose to browse artists again, it's
up at the top of the list again. Previous releases didn't exhibit this problem. Which debugging options can I turn
on to help the process?

Thanks,
Marc

Comment 1 Marc Reichman 2006-07-06 22:39:50 UTC

I just verified this also happens in SoftSqueeze.

Comment 2 Michael Herger 2006-07-07 09:22:14 UTC

What exact version is this (see Server Settings at the bottom)?

Can you remember when you first saw this happen?

Comment 3 KDF 2006-07-07 10:13:40 UTC

Seems that this only applies to Artists listings.

If I browse albums, genres or years, there was no problem going back to where it left off.
Artist, however, does return to Various Artists.

Comment 4 Michael Herger 2006-07-07 10:26:08 UTC

Hmm... Ok, I can reproduce it if I've grouping of compilations enabled. There are no various artists without :-). When disabled, it correctly jumps to where I left.

Comment 5 KDF 2006-07-07 10:44:07 UTC

problem is here:
2006-07-07 10:42:14.5014 browsedb - hierarchy: artist,album,track level: 0
2006-07-07 10:42:14.5241 last position from selection key artist,album,track:0:contributor.role=15album.compilation=HASH(0x574ea30)HASH(0x574c984) is 0

another issue with the album.compilation hash.  it doesn't match up right so the last selection gets lost.

Dan any tips?  I'll see if I can hack up something while we wait :)

Comment 6 KDF 2006-07-07 11:00:05 UTC

this turned out to be easy.
borrowing from svn 8076, add this after line 733 of Slim/Buttons/BrowseDB.pm:
			if (ref($v) eq 'ARRAY' && $k eq 'album.compilation') {
				$v = 0;
			}

Comment 7 Marc Reichman 2006-07-07 11:37:54 UTC

I can confirm this works. Thanks!

Comment 8 KDF 2006-07-07 13:22:29 UTC

Thanks.  I'll merge this inot the nightly builds tonight.  Assigning to myself for reference.  Dan, anything problematic that you see with this, let me know.

Comment 9 KDF 2006-07-07 20:20:07 UTC

fixed at change 8327 for 6.3.1 nightly builds.