Bug 3678 - Requests for Handheld skin
: Requests for Handheld skin
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.2.2
: PC Windows XP
: P2 enhancement (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-01 20:55 UTC by Sue Chastain
Modified: 2008-09-15 14:39 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Mixerlink for the Handheld skin (1.24 KB, application/zip)
2006-07-07 01:49 UTC, Michael Herger
Details
The real Handheld skin for MIPM (1.28 KB, application/zip)
2006-07-09 23:48 UTC, Michael Herger
Details
working Handheld skin for MusicIP (1.81 KB, application/zip)
2006-07-12 05:02 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sue Chastain 2006-07-01 20:55:39 UTC
In the Handheld skin, there is no icon for a MusicIP Mix in the browse screens. Instead you just have the text "MusicMagic Mix" which takes up a lot of space on a skin that is designed for handhelds. Also, I'd love to see sleep timer functions added to this skin.
Comment 1 Blackketter Dean 2006-07-06 15:08:18 UTC
Michael: is this something you can look at?
Comment 2 Michael Herger 2006-07-07 00:14:09 UTC
I'll do my best. You've set the target to 6.5 - no need for 6.3?
Comment 3 Michael Herger 2006-07-07 01:49:43 UTC
Created attachment 1318 [details]
Mixerlink for the Handheld skin

Sue, could you please give this a try? I don't have MusicMagic, therefore can't test. But it should replace that lengthy test with the icon as you know it from the Default skin.

Just uncompress that zip file to Plugins/MusicMagic/HTML/. It should create a new subfolder Handheld, which contains the skin bits needed.

Please let me know if this works so I can check it in into the latest sources. Thanks.
Comment 4 KDF 2006-07-07 13:52:25 UTC
another way:

for the MIP graphic...
copy Default/html/images/b_mmmix.gif to Handheld/html/images

add to Handheld/cmdwrappers_Handheld:
[% controlGraphics  = 1 %]

and add to Handheld/skin.css:
IMG {
	border: 0px;
}


Doing it this way, will then allow the trackstat plugin to add its graphic link.  And if you copy Default/html/images/b_mix.gif, you also get MoodLogic working with a graphic.

Comment 5 Michael Herger 2006-07-07 23:54:58 UTC
thanks for the 6.5 solution :-). I first wanted to go the easy way of 6.3 just to understand whether this was going to fix the issue. As I don't have MIP I can't verify (I know, it can be downloaded for free, I would get a key and all...)
Comment 6 Sue Chastain 2006-07-09 18:24:12 UTC
Michael: Sorry... It didn't work. There's no icon, and the only difference is the "MusicMagic Mix" text now has a colored background, like highlighting. On my Pocket PC it's red and on my desktop it's yellow. BTW, not sure if it matters but I went from 6.2.2 to 6.3.1 from the time I made this request to now.

Thanks.
Comment 7 KDF 2006-07-09 21:40:44 UTC
I think enhancements are still slated for 6.5 only (indicated again by the target of this bug).  I'll volunteer to test and tweak a patch for 6.3 if one is desired, but I'll leave that to Chris to decide.
Comment 8 Michael Herger 2006-07-09 23:48:08 UTC
Created attachment 1323 [details]
The real Handheld skin for MIPM

Sue, I'm sorry I uploaded the wrong file :-(. So here's a new one. I hope this time I'm right...

Kevin, I thought it would be easier for me to come up with a first solution in 6.3 - and then do 6.5. The inheritance in 6.5 doesn't always simplify things if you're not up to date with the hierarchy. But I haven't forgotten 6.5.
Comment 9 Michael Herger 2006-07-09 23:50:19 UTC
Oh, and I'd consider this a fix, not an enhancement :-)
Comment 10 Sue Chastain 2006-07-10 10:21:45 UTC
With the latest zip, the text is now an icon, but it doesn't do anything (not a link), and it also still has the colored highlight background.
Comment 11 Michael Herger 2006-07-10 13:26:25 UTC
Kevin, I'm trying to get a demo key for MusicIP - who was the man to ask for this? I know he's been in the forums, too, but I can't remember his name.
Comment 12 Sue Chastain 2006-07-10 13:57:48 UTC
Pretty sure the 1.6 version he has for download on the site now has all the SlimServer integration in the free version, so I don't think you need a key for testing w/ Slimserver. 
Comment 13 Michael Herger 2006-07-12 05:02:16 UTC
Created attachment 1337 [details]
working Handheld skin for MusicIP

Ok, this time it should work. I finally got MusicIP up and running on my system - which definitely eases the testing :-). There's a new template for the mix page, too.
Comment 14 Sue Chastain 2006-07-12 09:14:13 UTC
Thanks, seems to work just fine!

I have been using this skin a lot lately. One thing I thought of last night that would be a nice addition, is to have the alphabar from the top of the page also repeated at the bottom. I find myself always having to scroll back to the top of the page to jump to another place.
Comment 15 Michael Herger 2006-07-12 09:19:53 UTC
Sue, thanks for the positive feedback. I'll check it in and add it to the trunk.

Don't expect the alphabar in the 6.3 branch as this is definitely an enhancement (but you're right - this happens to me, too! :-))
Comment 16 Michael Herger 2006-07-12 12:15:38 UTC
Change 8402 added mixer icons to the trunk - was _way_ easier than for 6.3...
Comment 17 Michael Herger 2006-07-12 12:30:25 UTC
Added the pagebar in changes 8405 and 8406 (trunk and 6.3 respectively). Should be in tomorrow's build.
Comment 18 KDF 2006-07-18 20:43:00 UTC
marking as fixed, with a changelog entry for 6.5.  6.3.1 is already tagged for release so too late for just a changelog entry.