Bug 3672 – Random Mix: 'Select All/None' also changes 'Add new items...'

Bug 3672 - Random Mix: 'Select All/None' also changes 'Add new items...'

Summary:

Random Mix: 'Select All/None' also changes 'Add new items...'

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5b1
Platform:	PC Fedora

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-07-01 12:11 UTC by Lars Lind Nilsson
Modified:	2009-01-29 09:47 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Patched randomplay_list.html (6.24 KB, patch) 2006-07-01 12:14 UTC, Lars Lind Nilsson	Details \| Diff
diff of the changes (503 bytes, patch) 2006-07-02 07:13 UTC, Lars Lind Nilsson	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Lind Nilsson 2006-07-01 12:11:33 UTC

When clicking the 'Select None'/'Select All' button on the Random Mix page it also changes the value of the 'Add new items when old ones finish' checkbox. I believe that it should only (un-)check all the genres.

Running on 6.5b July 1st nightly, but I also believed it was a problem when I was running on 6.2.x

A simple change to the JavaScript function selectAll in 'Plugins/RandomPlay/HTML/EN/plugins/RandomPlay/randomplay_list.html' should fix the problem.

Add an extra condition in the first if statement so it looks like this:

if (f.elements[i].type == 'checkbox' && f.elements[i].name != 'continuousMode')

Comment 1 Lars Lind Nilsson 2006-07-01 12:14:15 UTC

Created attachment 1299 [details]
Patched randomplay_list.html

randomplay_list.html with the suggested change added.

So someone with the prober skills and SVN rights can verify and check in.

Comment 2 KDF 2006-07-02 00:49:50 UTC

are you able to attach a 'diff -upB' against the old file?

if you use svn: svn diff randomplay_list.html > randomplay_list.diff

if you don't: diff -upB randomplay_list.html.old randomplay_list.html.patched > randomplay_list.diff

easier for a dev to merge and verify.
thanks.

Comment 3 Lars Lind Nilsson 2006-07-02 07:13:22 UTC

Created attachment 1300 [details]
diff of the changes

Here are a diff of the changes I made to the randomplay_list.html

Comment 4 Dan Sully 2006-07-05 11:38:42 UTC

This seems ok to me..

Comment 5 Dan Sully 2006-07-06 10:57:02 UTC

Fixed in change 8300