Bug 3662 - Disc # = 1 ignored in multi-dics sets
: Disc # = 1 ignored in multi-dics sets
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.3.0
: PC Linux (other)
: P2 major (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-30 06:04 UTC by Patrick Dixon
Modified: 2008-12-15 11:58 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
stripped flac file (4.51 KB, application/octet-stream)
2006-07-02 08:44 UTC, Patrick Dixon
Details
stripped flac (4.83 KB, application/octet-stream)
2006-07-02 08:44 UTC, Patrick Dixon
Details
Song 1 Disk 1 (4.45 MB, audio/mpeg)
2006-07-02 14:42 UTC, Michael Herger
Details
Song 1 Disk 2 (2.49 MB, audio/mpeg)
2006-07-02 14:44 UTC, Michael Herger
Details
Pink Floyd The Wall trimmed flacs (17.34 KB, application/x-zip-compressed)
2006-07-02 15:03 UTC, Mike Cappella
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Dixon 2006-06-30 06:04:53 UTC
Released 6.3
CC3.2
Fishbone

Multi disc album sets correctly tagged with disc 1 are not recognised.  Album is listed just with track numbers and not correctly assigned to mult-disc set.  Disc 2 is correctly recognised but not tied in with Disc 1.

The tags are correct and work 6.2 and 6.5b1
Comment 1 Patrick Dixon 2006-07-02 03:28:37 UTC
Just to clarify:-

This is with both Player and web UI.
Using Group Multi-Disc Albums together setting.
Comment 2 Fred 2006-07-02 05:17:21 UTC
Fishbone, OS X, iTunes tagging, 6.3.0 release => Multi disk are properly recognized.

Therefore additional details are needed to progress on this. "Correctly tagged" songs upload, or debug output of scanning. Tried trashing the DB and rescan all?

Comment 3 Patrick Dixon 2006-07-02 05:31:20 UTC
Tagged using Tag&Rename (iTunes free zone).

Converting to MySQL produces the same result as the 'out of the box' SQLite installation, but shows that the MySQL db is correctly assigning Disc and Discc to 1 or 2 - so it's not a tags/scanning problem.

Trashing the db and resacnning (before moving to MySQL) made no difference.

SlimServer Version: 6.3.0 - 8154 - Linux - EN - utf8 
Comment 4 Dan Sully 2006-07-02 08:03:45 UTC
Patrick - can you please upload some example files you are having trouble with?

It's working fine for me here.

Thanks
Comment 5 Patrick Dixon 2006-07-02 08:15:10 UTC
This also now occurs in 6.5b1 too.

Dan - they're FLAC files so they are too big to upload, although you should be listening to more Led Zeppelin anyway ....

Here's some output from my (6.3.0) MySQL albums table though:-

*****************************************

  id  title  titlesort  titlesearch  contributor  compilation  year  artwork_path  disc  discc  replay_gain  replay_peak  musicbrainz_id  musicmagic_mixable  

      2 Remasters REMASTERS REMASTERS 2 NULL 1990 25 1 1 NULL NULL NULL NULL 
      3 Remasters REMASTERS REMASTERS 2 NULL 1990 40 2 2 NULL NULL NULL NULL 
      4 The Song Remains The Same SONG REMAINS THE SAME SONG REMAINS THE SAME 2 NULL 1976 51 1 1 -2.13 0.999969 NULL NULL 
      5 The Song Remains The Same SONG REMAINS THE SAME SONG REMAINS THE SAME 2 NULL 1976 56 2 2 -2.13 0.999969 NULL NULL 

******************************************
 
Here's the track list for Remasters Disc 1:-

All Songs          
1. Communication Breakdown by Led Zeppelin from Remasters          
2. Babe I'm Gonna Leave You by Led Zeppelin from Remasters          
3. Good Times Bad Times by Led Zeppelin from Remasters          
4. Dazed And Confused by Led Zeppelin from Remasters          
5. Whole Lotta Love by Led Zeppelin from Remasters          
6. Heartbreaker by Led Zeppelin from Remasters          
7. Ramble On by Led Zeppelin from Remasters          
8. Immigrant Song by Led Zeppelin from Remasters          
9. Celebration Day by Led Zeppelin from Remasters          
10. Since I've Been Loving You by Led Zeppelin from Remasters          
11. Black Dog by Led Zeppelin from Remasters          
12. Rock And Roll by Led Zeppelin from Remasters          
13. The Battle Of Evermore by Led Zeppelin from Remasters          
14. Misty Mountain Hop by Led Zeppelin from Remasters          
15. Stairway To Heaven by Led Zeppelin from Remasters  

And here it is for Remasters Disc 2:-

All Songs          
2-1. The Song Remains The Same by Led Zeppelin from Remasters          
2-2. The Rain Song by Led Zeppelin from Remasters          
2-3. D'yer Mak'er by Led Zeppelin from Remasters          
2-4. No Quarter by Led Zeppelin from Remasters          
2-5. Houses Of The Holy by Led Zeppelin from Remasters          
2-6. Kashmir by Led Zeppelin from Remasters          
2-7. Trampled Underfoot by Led Zeppelin from Remasters          
2-8. Nobody's Fault But Mine by Led Zeppelin from Remasters          
2-9. Achilles Last Stand by Led Zeppelin from Remasters          
2-10. All My Love by Led Zeppelin from Remasters          
2-11. In The Evening by Led Zeppelin from Remasters          

        
 
 

Comment 6 Dan Sully 2006-07-02 08:18:23 UTC
Patrick - you can use Robin's script here:

http://forums.slimdevices.com/showthread.php?t=17228

To generate flac files with metadata, but without audio data.

If you could upload a zip of those, that would be great..

From looking at the mysql output - what is the tag value of DISCC for Remasters disc 1? It looks like it is 1 when it should be 2.
Comment 7 Patrick Dixon 2006-07-02 08:26:20 UTC
disc and discc are both the same 1 & 1 or 2 & 2 - I guess that's the problem then?

I'll upload some files - I also have a George Michael double CD (don't ask) which is blown into 10 for some reason.
Comment 8 Dan Sully 2006-07-02 08:30:11 UTC
Yes - some example files would be great.

I do love Zeppelin, and I won't ask about the George Michael. :)
Comment 9 Patrick Dixon 2006-07-02 08:44:31 UTC
Created attachment 1301 [details]
stripped flac file
Comment 10 Patrick Dixon 2006-07-02 08:44:57 UTC
Created attachment 1302 [details]
stripped flac
Comment 11 Dan Sully 2006-07-02 09:01:03 UTC
So the issue here is that you don't have a DISCC set
Comment 12 Patrick Dixon 2006-07-02 09:15:31 UTC
I never had and it's previously worked correctly.

AFAIK Tag&Rename (which is one of the more popular Tagging programs) has no provision to set the number of Discs in a  set.
Comment 13 Patrick Dixon 2006-07-02 09:24:21 UTC
In any event, when 'Group Multi Disc Albums' is set, surely the number of Discs in the set is not relevent?

If the album and artist tags are the same, they must be the same album and should be grouped as such, using the disc tag to prefix the track number.

I leave disc unset for single CDs and set disc = 1,2,3, etc for multi-disc sets.  I'm not sure how else I can tag it.
Comment 14 Dan Sully 2006-07-02 10:05:25 UTC
Ok - thanks. I'll try and figure out what's going on.

Comment 15 Michael Herger 2006-07-02 13:27:05 UTC
I don't have much to add here. I experience the same problem with MP3 files (no DISCC neither). Are you still interested in demo files?
Comment 16 Michael Herger 2006-07-02 13:32:35 UTC
...oh, but I do have the TPOS tag set.
Comment 17 Michael Herger 2006-07-02 14:42:23 UTC
Created attachment 1311 [details]
Song 1 Disk 1

First song of first disk "The Lamb Lies Down on Broadway" by Genesis
Comment 18 Michael Herger 2006-07-02 14:44:27 UTC
Created attachment 1312 [details]
Song 1 Disk 2

First song of second disk "The Lamb Lies Down on Broadway" by Genesis
Comment 19 Mike Cappella 2006-07-02 15:03:59 UTC
Created attachment 1313 [details]
Pink Floyd The Wall trimmed flacs

Here are my trimmed FLAC files for Pink Floyd's The Wall.
Comment 20 Dan Sully 2006-07-02 17:01:44 UTC
Fixed in change 8249
Comment 21 Patrick Dixon 2006-07-03 01:26:51 UTC
Thanks Dan, I've patched my 6.3.0 and it looks good - it even fixes my George Michael problem.  Well, the tags part anyway ;-)

Much appreciated.
Comment 22 Patrick Dixon 2006-07-04 01:52:48 UTC
Shouldn't this be in trunk too?
Comment 23 Dan Sully 2006-07-04 08:13:43 UTC
Yes - it's changed in my copy of trunk - I have some other pending changes, so it's not been submitted yet.
Comment 24 Ross Levine 2006-07-07 17:26:53 UTC
SlimServer Version: 6.3.1 - 8278 - Mac OS X 10.4.7 (8J135) - EN - utf8

Not linux, but on OS X this looks as it should, verified. 
Comment 25 James Richardson 2008-12-15 11:58:08 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.