Bug 3652 - Group compilations, Various Artists and WMA files
: Group compilations, Various Artists and WMA files
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.3.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-28 20:07 UTC by Mike Cappella
Modified: 2009-09-08 09:13 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cappella 2006-06-28 20:07:28 UTC
I think I found another case where Group compilations is not working correctly. I noticed this with my remaining WMA files. All artists from the tracks are showing up under Browse Artists, as is the artist "Various Artists"

Album is stored in the music directory as Various Artists\Album.

Each track in the album is tagged with WMA tags (relevant ones shown):

Title: song's title
Author: track's author
WM/AlbumTitle: albums's title
WM/AlbumArtist: Various Artists

6.3 svn 8183

I have test files if useful.
Edit/Delete Message
Comment 1 Chris Owens 2006-06-29 11:55:32 UTC
Ross if you have time, could you have a look at this?  Otherwise, feel free to assign it back to me.  You'll want to either convert your 'albums' to WMA or rip a couple of CDs (I have some if you need) and edit the tags.
Comment 2 Mike Cappella 2006-06-29 12:20:12 UTC
I've created a zip file that contains some tracks, in the proper directory structure if you want a quick test case.
Comment 3 Ross Levine 2006-06-29 13:24:23 UTC
(In reply to comment #2)
> I've created a zip file that contains some tracks, in the proper directory
> structure if you want a quick test case.
> 

Would you mind uploading them here? If you can't do that, can you email them to me (ross@slimdevices.com)?
Comment 4 Mike Cappella 2006-06-29 13:39:56 UTC
I've sent a link to you via email.
Comment 5 Ross Levine 2006-06-29 14:35:42 UTC
SlimServer Version: 6.3.0 - 8132 - Windows XP - EN - cp1252

I was able to reproduce this bug. When grouping either as multiple albums or single album (group disc within behaviour) the artists show up accurately, but also show up as various artists. Using the test files from Mike Cappella:

\\roscoxp\bug 3652
Comment 6 Chris Owens 2006-06-29 15:12:51 UTC
Having let this bug through makes me fairly unhappy.  Is a 6.5 nightly the right target for this?
Comment 7 Dan Sully 2006-06-29 15:15:35 UTC
It depends. It might already be fixed in 6.5 :)
Comment 8 Mike Cappella 2006-06-29 16:03:56 UTC
Sorry to be the source of your unhappiness!  Its not high priority for me, but others might like a 6.3.x fix.
Comment 9 Dan Sully 2006-06-29 16:53:51 UTC
Also - it'd be useful if the files were attached to this bug.

Thanks
Comment 10 Mike Cappella 2006-06-29 16:57:28 UTC
I didn't want to post ripped tracks, as they are available to anyone who wants to download them.  I didn't see any other way to post data that would be accessible to slimdevices only.
Comment 11 Dan Sully 2006-06-29 16:59:06 UTC
Ok.. fire away with a link then.. I'd like to see if this is an issue under 6.5.

Thanks
Comment 12 Ross Levine 2006-06-29 17:10:13 UTC
Emailed link to Dan. Also I've made the files available \\roscoxp\bug 3652 which may not do DS much good. Sorry about that. 
Comment 13 Dan Sully 2006-06-29 17:34:52 UTC
FYI, works fine in 6.5
Comment 14 Ross Levine 2006-06-29 18:57:30 UTC
Tried in 6.5, sure enough it shows up as it should, as Various Artists. I suppose the various behavioural options are still in the works. 
Comment 15 Dan Sully 2006-07-02 22:57:10 UTC
So this is a dupe of bug 2638.

The fix for 6.5 went in as change 8140 - line 1640 is the relevant part.

I think this will be safe for 6.3.1

Chris / Dean, your thoughts?
Comment 16 Mike Cappella 2006-07-03 09:52:02 UTC
Dan,

I merged your (relevant) changes into my 6.3 latest SVN, and the fixes appear to work.  There is one minor nit for your consideration.

When Album Artist is set to "Various Artists", with FLAC files, the Artist shown under Browse Artists gets mapped to what is set in the VariousArtistsString prefs value.  In my case, its "(Various Artists)" for sorting at the top of the browse list.

However, for WMA files, with the same Album Artist setting of "Various Artists", the Artist shown under Browse Artists is left as "Various Artists" and is *not* mapped to the value in VariousArtistsString.

The inconsistency creates both "(Various Arists)" and "Various Artists" in the browse lists.  I suppose I could remove all the Album Artist tags that are set to "Various Artists" and the problem might go away, but since WMA files actually use WM/AlbumArtist tags (which I know internally get mapped to AlbumArtist), I'm not sure and didn't want to proceed without comment from you.

As background, I setup Album Artist on all my compilation albums to Various Artists in J.River's MC, to override their use of the string "(Multiple Artists)" when no Album Artist is set and tracks have different artists.
Comment 17 Dan Sully 2006-07-11 13:13:38 UTC
Ok Mike - I'm not going to merge the change into 6.3.1, but I will take a look at the VA issue for 6.5
Comment 18 Dan Sully 2006-07-13 16:31:11 UTC
Mike - so the best thing to do would be to change your FLAC files to be just 'Various Artists', change the 'Various Artists String' in SlimServer's Settings, or possibly remove the string from your FLAC files completely, and set COMPILATION=1

Not much I can do in SlimServer itself.
Comment 19 Mike Cappella 2006-07-13 17:57:28 UTC
Thanks for the time investigating Dan.  Its really no big deal either way for me, as I'll be ditching the remaining WMA files anyway.  I was just noting the minor apparent inconsistencies in my situation.