Bug 363 - some mp3 streams crashes slimserver under Mac OS X
: some mp3 streams crashes slimserver under Mac OS X
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 5.x or older
: Macintosh MacOS X 10
: P2 major (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-06-09 01:23 UTC by Peter Speck
Modified: 2011-03-16 04:18 UTC (History)
0 users

See Also:
Category: ---


Attachments
patch which fixes problem and adds more $::d_remotestream debugging. (1.32 KB, patch)
2004-06-09 01:25 UTC, Peter Speck
Details | Diff
improved patch (1.36 KB, patch)
2004-06-09 03:17 UTC, Peter Speck
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Speck 2004-06-09 01:23:38 UTC
I'm playing an mp3 stream (from iTunes playlist):
http://64.236.34.97:5190/stream/1006
which is "M O S T L Y - C L A S S I C A L" from http://di.fm

It plays for about 3 to 4 minutes without problems, and then the client tells it has lost connection to the 
server, and a few seconds later, this is in /tmp/slimerror.log

Quantifier in {,} bigger than 32766 in regex; marked by <-- HERE in m/^((?:vfD_[^_]+_Vfd|(?:__(?:
cursorpos|center)__)?(?:__(?:cursorpos|center)__)(?:vfD_[^_]+_Vfd|.)|.){ <-- HERE 0,41621})/
2004-06-08 05:40:22.4889 Got to the END.
2004-06-08 05:40:22.4900 Got sigint.
2004-06-08 05:40:22.4906 SlimServer cleaning up.

This is caused by sysread() in Slim::Web::RemoteStream::readMetaData returning undef and still adds 
data to the 2nd arg. This makes $metadata grow witout bounds, so it becomes +32K, and then 
slimserver crashes.

Patch for this is attached to bug report.
Comment 1 Peter Speck 2004-06-09 01:25:15 UTC
Created attachment 44 [details]
patch which fixes problem and adds more $::d_remotestream debugging.
Comment 2 Peter Speck 2004-06-09 03:17:33 UTC
Created attachment 45 [details]
improved patch

can't do next inside do..while() in perl, so here's an improved patch

patch fixes problem and adds more $::d_remotestream debugging.
Comment 3 Vidur Apparao 2004-06-09 07:02:20 UTC
Approving for 5.2, but would like to get some eyes on the patch.
Comment 4 Blackketter Dean 2004-06-11 11:47:58 UTC
Should be fixed in the latest nightly.  
Comment 5 Chris Owens 2007-05-24 15:54:08 UTC
This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.
Comment 6 Chris Owens 2008-12-18 11:54:47 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.