Bug 3598 - SHOUTcast search issue
: SHOUTcast search issue
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: PC Windows Server 2003
: P2 normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-17 22:02 UTC by Alex
Modified: 2006-06-18 11:57 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
allow play on index=0 (376 bytes, patch)
2006-06-17 22:55 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2006-06-17 22:02:41 UTC
In Fishbone select SHOUTcast search and type WNYC, and click add to the playlist link on "WNYC2 24/7 Classical". The add fails and the same search result screen is displayed in the player window
Comment 1 KDF 2006-06-17 22:21:21 UTC
Please try other skins.
Comment 2 KDF 2006-06-17 22:39:14 UTC
This is not entirely correct.  It seems to be the first link, when the index is zero.  Otherwise the links do appear to play on at least Fishbone, EN, Default (all using cmdwrappers).  However, sometimes it seems to require a second click

sample failing link:
ShoutcastBrowser/index.html?query=jack&action=play&index=0&player=<player>
Comment 3 KDF 2006-06-17 22:55:18 UTC
Created attachment 1275 [details]
allow play on index=0

This appears to fix the problem.  however, I'm unsure as to what the need might be for having @index set to ''.  If it is only to avoid an undeff warning at some point, I'd suggest another way to blocking that.
Comment 4 Blackketter Dean 2006-06-18 08:58:31 UTC
is this 6.5 only or does it also affect 6.3?
Comment 5 Andy Grundman 2006-06-18 09:06:11 UTC
6.3 contains the correct line, so this only affects 6.5.  That extra code was probably added due to the extra warnings being reported in 6.5.  Feel free to apply that patch kdf, thanks.
Comment 6 KDF 2006-06-18 11:57:36 UTC
Committed to trunk at change 8043
Will tackle the warnings as they come up, if any do appear.