Bug 3595 – Upgrading/downgrading between 6.3/6.5 perilous

Bug 3595 - Upgrading/downgrading between 6.3/6.5 perilous

Summary:

Upgrading/downgrading between 6.3/6.5 perilous

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	CLI
Version:	6.3.0
Platform:	Macintosh Other

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-06-17 12:07 UTC by Blackketter Dean
Modified:	2008-09-15 14:38 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2006-06-17 12:07:53 UTC

The default dbsource is added to the preferences without a means to change or edit it.  This means that for most users, if they upgrade/downgrade between 6.3 and 6.5 they'll have a bogus dbsource.

We shouldn't save this pref unless it's changed from the default, so the built-in database is used unless the user changes it manually.

Comment 1 Dan Sully 2006-06-18 08:57:25 UTC

Upgrading & downgrading does the right thing now, wrt the built-in database, and swapping between versions.

See change 8033

Comment 2 Blackketter Dean 2006-06-18 09:05:31 UTC

Dan:  why are we persisting this in the preference file?  The upgrade/downgrade scripts seem like a hack solution on the problem of adding to the prefs file needlessly?

Comment 3 Dan Sully 2006-06-18 09:11:39 UTC

Because someone that is poking through the slimserver.pref file needs to see that dbsource is in there, and editable if they want to change it.

We're not using the upgrade-scripts functionality anymore, as that only runs once.

Comment 4 Dan Sully 2006-06-18 14:56:44 UTC

Can I close this?

Comment 5 Blackketter Dean 2006-06-20 11:51:07 UTC

ok, if it doesn't affect users anymore, we can close.

Comment 6 Chris Owens 2006-06-27 14:21:53 UTC

This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.