Bug 3582 - Various artists setting blocks selection of other artists
: Various artists setting blocks selection of other artists
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.3.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-16 08:43 UTC by Mick
Modified: 2008-09-15 14:38 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mick 2006-06-16 08:43:33 UTC
SlimServer Version: 6.3.0 - 8002 - Windows XP - EN - cp1252

When Server Settings->Behaviour->Compilations is set to "Group compilation albums together", the only artists which can be added to the playlist from the Player UI using Browse "Artists" are albums in the various artists group.

When an album from an individual artist is selected, the songs are not added to the playlist for playback.
The same artists can be added to the playlist from the Web UI.

The Browse Album & Browse Year functionality still works fine because these groups do have a "Various Artist" pseudo group.
Comment 1 Tim Fletcher 2006-06-19 05:15:16 UTC
*** Bug 3603 has been marked as a duplicate of this bug. ***
Comment 2 Chris Owens 2006-06-20 11:46:21 UTC
So the player and web UI behavior is different?  I can try to reproduce that.
Comment 3 Mike Cappella 2006-06-20 11:52:13 UTC
Yes, you can use the web UI to queue up albums, but the player remeote and softsqueeze controls fail.
Comment 4 KDF 2006-06-20 11:52:48 UTC
Has to do with the following line used in DataStores::Base and DBI::DBIStore:

$findCriteria->{'album.compilation'} = [ { 'is' => undef }, { '=' => 0 } ];

This confuses the BrowseDB->play command, which then sends "album.compilation=HASH(0x5447544)HASH(0x5447964)" as part of the loadtracks command.

I don't know for sure what album.compilation does when it comes to the loadtracks command on a chosen artist, so we may be able to simply delete it when the $termlist is being contructed?
Comment 5 KDF 2006-06-20 12:20:23 UTC
as a matter of fact, I can see tha tthe web UI never makes use of the param for play controls.

so, adding the following just before Buttons/BrowseDB.pm line 161 seems to work:
delete $findCriteria->{'album.compilation'};
Comment 6 Dan Sully 2006-06-20 12:27:22 UTC
The web UI probably should make use of that param.. but I'd need a test case.
Comment 7 KDF 2006-06-20 12:34:44 UTC
could do.  my notes were more to focus on the problem point.  obviously the album.compilation param needs to be turned into a hash everywhere it is used, instead of assigned with 1. then the termlist mappings can handle it specifically as a hash.
Comment 8 Dan Sully 2006-06-21 11:45:15 UTC
Fixed in change 8076
Comment 9 Simon Turner 2006-06-23 00:01:24 UTC
I installed the two new Perl files listed (BrowseDB.pm and Command.pm from 21st June) and then, later, installed the nightly from the 22nd June:
For me only one issue has been fixed.
Browse Music/Artists/Album    play whole album. Fixed with latest release.
Browse Music/Album   play whole album. Plays as expected (and might have always done)
Browse Music/Artists    play whole artist. No songs populate playlist

There may be other vagaries too, but these are the only one's I've tested.
Individual tracks play fine if selected singly.
The Slimserver GUI works fine, it's only the remote that has the problem (I don't know about SoftSqueeze).
I have "Group compilation albums together" selected
XP Home.

This seems to be related to the problem above, but not exactly the same.
Comment 10 KDF 2006-06-23 10:08:42 UTC
seem like there are a couple of outstanding issues with this.
cc'ing chris to reverify the PLAY function on browse db items.
Comment 11 Dan Sully 2006-06-23 14:04:35 UTC
Simon's Artist playing problem is fixed in change 8117
Comment 12 Simon Turner 2006-06-24 07:13:15 UTC
I'm afraid SlimServers "Artist Problem" does not appear to have been fixed for me. I installed the new Base.pm script and slso the latest nightly (although I think it may be previous to the change to Base.pm) and both still gave me the sawme problem: i.e. Browse Music/Artists - play whole artist. No songs populate playlist.
What is odd is that after a few seconds an old playlist began to play, one that I had cleared from the web GUI quite a while ago (and SlimServer had been stopped and started quite a few times since I cleared it).
In addition now most of my tracks as listed in SlimServer are duplicated.... I guess I'd better try to see if there's a current bug for that too.
Comment 13 Dan Sully 2006-06-24 11:04:19 UTC
Simon - please uninstall completely, and reinstall the June 24th nightly. Replacing individual files will not work.

Thanks
Comment 14 Mike Cappella 2006-06-24 19:45:11 UTC
FWIW, it's been working great for me.
Comment 15 Chris Owens 2006-06-27 14:21:52 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.