Bugzilla – Bug 3476
Discrepancy between Squeezebox and Softsqueeze
Last modified: 2011-03-16 04:39:14 UTC
I made very simple modifications to the "Command.pm" file. My goal is to prevent the playlist from clearing when "play" is pressed, and jumping to the first added track. Modification A I commented out the following line: Slim::Player::Playlist::clear($client) Modification B The following section: if ($p1 =~ /^(play|load)$/) { $jumpToIndex = 0; } became: if ($p1 =~ /^(play|load)$/) { $jumpToIndex = Slim::Player::Playlist::count($client); } Result : Produces the desired result on Softsqueeze. Tracks are added, and the first added track is played. On Squeezebox, seems to work OK on individual tracks, but produces incorrect results when playing a folder (while browsing the music folder) when there already is something in the current playlist. The tracks are added, but the wrong track is played. Thanks,
Check your prefs for "play other songs in album" under server settings->behavor. There is special logic to handle playing other tracks in the same folder, since it has to keep track of non-audio files when determining the first song to play. This means that your code changes will be problematic when selecting a track within a folder when the above setting is set to "play other songs..." This shouldn't be different between softsqueeze and squeezebox however. Please include d_command log output and ensure that you are doing the exact same button presses or link clicks for both cases. also worth checking latest nightly builds (as it says on the bugzilla main page). 6.3.0 for stable, 6.5b1 for unstable (many changes in command structure that may affect this specific case)
(In reply to comment #1) > Check your prefs for "play other songs in album" under server > settings->behavor. > There is special logic to handle playing other tracks in the same folder, since > it has to keep track of non-audio files when determining the first song to > play. This means that your code changes will be problematic when selecting a > track within a folder when the above setting is set to "play other songs..." It was set to play only the selected song. So although my code change would be buggy in that case, it is not my current problem. Please note also that I have tried both playing a whole directory and a single file, with the same incorrect result. > This shouldn't be different between softsqueeze and squeezebox however. Please > include d_command log output and ensure that you are doing the exact same > button presses or link clicks for both cases. They seem identical, save for the timestamps of course. I attached the files if you want to check for yourself. For both, I deleted the messages files and restarted the server before adding the files. > > also worth checking latest nightly builds (as it says on the bugzilla main > page). 6.3.0 for stable, 6.5b1 for unstable (many changes in command structure > that may affect this specific case) I will try that next.
Created attachment 1256 [details] Messages file when using softsqueeze When doing this on softsqueeze, everything happens as expected.
Created attachment 1257 [details] Same steps repeated on the squeezebox On the squeezebox, the file that plays after adding the second folder (Beethoven) is still a song from the first folder (Bach).
Is this still a problem with 6.3 or 6.5 builds?
(In reply to comment #5) > Is this still a problem with 6.3 or 6.5 builds? > I downloaded 6.5 but I get an error when starting it (something about Digest::MD5, object versions, versions 2.36/2.33... I don't know what it is). 6.2.2, which worked perfectly before, gives out the same error now. It seems to be a problem with Perl, not with Slimserver. I did a big update today on my system, it may very well be related to that. Sorry, I have to figure out how to solve that problem before I can make more tests...
Ok... Perl problem solved. I Installed 6.3, made the code change, and it works OK on the Squeezebox. I don't remember being prompted to upgraded the firmware. I installed 6.5, made the code change, and it works OK on the Squeezebox. I was prompted to upgraded the firmware. I thought I would give my old 6.2.2 install a try again, and try removing the player and making sure its settings were brought back to default. If that had failed, I would have gone for a fresh install. But... As soon as I started the old install, it worked. I did nothing, except for upgrading the firmware when prompted to (probably a downgrade?). I don't think the 6.5 and 6.3 touched the preference file or database, because my "production" install uses a home folder for slimserver and everything is configured in the init script. The only explanation I can find is that the firmware upgrades made a difference, but it makes little sense to me. Any idea? Did I hallucinate?
Frederic is I understand correctly from your comments this problem is fixed now. Can I close this bug?
> Frederic is I understand correctly from your comments this problem is fixed > now. Can I close this bug? Ok. I think I found it. When "shuffle" is off, everything works fine. When "shuffle by song" is active, the problem shows up. Here I was looking for esoteric explanations, but it was just that. Silly me. This may be as it was meant, so it may not be a bug per se. It feals weird though. To me, it would be more logical, when adding a folder (or album) to the playlist, to add all the songs at the end of the playlist, shuffling them but not touching the order of the songs that were previously there. You may disagree.
We'll refer back to this bug the next time we consider the adding-to-a-shuffled-playlist behavior.