Bug 346 – iTunes network streams broken

Bug 346 - iTunes network streams broken

Summary:

iTunes network streams broken

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	iTunes
Version:	5.x or older
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-06-05 18:07 UTC by Peter Speck
Modified:	2008-12-18 11:54 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
proposed patch (958 bytes, patch) 2004-06-07 19:40 UTC, Vidur Apparao	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Speck 2004-06-05 18:07:55 UTC

Latest revision to iTunes.pm (1.48) makes slimserver to ignore all non-file entries from the iTunes 
database, e.g. mp3 streams.

This is because the following code is executed no matter what the URL scheme is:
            my $file = Slim::Utils::Misc::pathFromFileURL($url, 1);
            if (!$file || !-r $file) {
                $::d_itunes && msg("iTunes: file not found: $file\n");
                $url = undef;
            }
thus it ignores all http://.... URLs.

Comment 1 Vidur Apparao 2004-06-07 19:40:18 UTC

Created attachment 43 [details]
proposed patch

Dean posted this patch to the Developer group.

Comment 2 Peter Speck 2004-06-07 20:03:55 UTC

Patch works fine for me. Just needs to be committed to CVS.

Comment 3 Vidur Apparao 2004-06-10 09:06:17 UTC

Fix checked in on 6/7/2004.

Comment 4 Chris Owens 2007-05-24 15:54:09 UTC

This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.

Comment 5 Chris Owens 2008-12-18 11:54:45 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.