Cc:ing dean and marking this as a 5.2 requirement.

this is a known issue, that I believe I had mentioned.  Unless there is some way
to actually tell the difference between disabled by server and disabled by user,
this cannot be solved without a rather large rework of the whole setup.  It
could, however, be solved one way, by a FAQ answer.
I'll see if I can think of anything else during the next week when I will have
the time.

here is one idea....
I'm not sure how to implement it yet, since I DID try something like this before
and it just made the code really ugly.  For the file types setting, I can set
them to show disabled, but not be added to the disabled formats.  This will
depend on being able to tell which setting the users change, and will take some
time to implement.

Maybe this is what you're suggesting...it seems like Source.pm::checkBin() is
setting the 'disabledformats' pref if it doesn't find the required binary.
Rather than setting the persisted pref, maybe it can just manage a separate
session-specific disabled list. That way, the next time SlimServer is launched
with the binary installed, we're good to go. What do you think of this patch?

Index: Slim/Player/Source.pm
===================================================================
RCS file: /home/cvs/cvsroot/slim/server/Slim/Player/Source.pm,v
retrieving revision 1.98
diff -u -r1.98 Source.pm
--- Slim/Player/Source.pm	2 Jun 2004 01:50:53 -0000	1.98
+++ Slim/Player/Source.pm	7 Jun 2004 21:30:23 -0000
@@ -38,6 +38,7 @@
 my $FADEVOLUME         = 0.3125;
 
 my %commandTable = ();
+my @sessionDisabledFormats = ();
 
 sub systell {
 	sysseek($_[0], 0, SEEK_CUR)
@@ -999,6 +1000,13 @@
 	
 	$::d_source && msg("Checking to see if $profile is enabled\n");
 	
+	for my $format (@sessionDisabledFormats) {
+		if ($format eq $profile) {
+			$::d_source && msg("!! $profile Disabled for this session!!\n");
+			return 0;
+		}
+	}
+
 	my $count = Slim::Utils::Prefs::getArrayMax('disabledformats');
 	
 	return 1 if !defined($count) || $count < 0;
@@ -1043,7 +1051,7 @@
 		if (!Slim::Utils::Misc::findbin($1)) {
 			$command = undef;
 			$::d_source && msg("   drat, missing binary $1\n");
-			unless ($profile eq 'mp3-lame-*-*')
{Slim::Utils::Prefs::push('disabledformats',$profile);}
+			unless ($profile eq 'mp3-lame-*-*') {push(@sessionDisabledFormats,$profile);}
 		}
 	}
 			

Dean brought up a good point. Why even worry about the disabling part? We're
going though checkBin at the start of every song anyway. Getting rid of the line
that starts with "unless ($profile eq 'mp3-lame-*-*')" will still do the right
thing, just not touch the disabledformats pref. The efficiency in disabling the
format conversion before the findbin check is not that significant, is it?

marking conversion as disabled is intended for use in the server settings.  When
a user views the file types list, the conversions that are unavailable due to
missing binaries, etc shoudl be shown as disabled.  However, maybe the settings
section can also make use of @sessionDisabled.

Fix checked in on 6/10/2004.

This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.