Bug 3437 - Patch: Maps J. River's MC "Disc #" tag to "DISCNUMBER"
: Patch: Maps J. River's MC "Disc #" tag to "DISCNUMBER"
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 6.3.0
: PC Windows XP
: P2 enhancement with 1 vote (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-22 08:28 UTC by Mike Cappella
Modified: 2008-09-15 14:38 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cappella 2006-05-22 08:28:23 UTC
J. River's MC and its FLAC decoder uses 'DISC #' rather than DISCNUMBER for FLAC files. The following (and attached) patch translates this to SlimServer's internal DISC tag.

--- Slim/Formats/FLAC.pm 2006-05-18 01:02:52.000000000 -0700
+++ Slim/Formats/FLAC.pm.new 2006-05-18 11:21:38.000000000 -0700
@@ -43,6 +43,7 @@
# J.River once again.. can't these people use existing standards?
   'REPLAY GAIN' => 'REPLAYGAIN_TRACK_GAIN',
   'PEAK LEVEL' => 'REPLAYGAIN_TRACK_PEAK',
+  'DISC #' => 'DISC',
);

my @tagNames = qw(ALBUM ARTIST BAND COMPOSER CONDUCTOR DISCNUMBER TITLE TRACKNUMBER DATE);


I've tested it, and it works for me. Is it possible that someone might check in this one-liner?
Comment 1 Dan Sully 2006-06-11 21:05:03 UTC
Fixed in change 7892
Comment 2 Mike Cappella 2006-06-12 10:41:06 UTC
Works peachy, thanks!
Comment 3 Craig Garnett 2006-06-12 23:22:35 UTC
Yes, thanks from me too.

Craig
Comment 4 Chris Owens 2006-06-27 14:22:10 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.