Bugzilla – Bug 3399
playing saved favorites using remote is broken
Last modified: 2008-09-15 14:38:25 UTC
reported on the forum: Not sure if this has come up before and also not sure if it's specific to 6.5 (which I'm running, using the deb package on an ubuntu machine, but I've noticed a peculiarity with the playback on internet radio favourites (on slimserver not squeezenetwork) using the remote. If I use the web interface to play back an internet radio station I've saved to favourite, it plays as expected. However, if I use the remote, press favourites, scroll to the station in question and press play, the playlist is cleared and the station added, but playback does not commence. Going to 'Now Playing', the station has appeared, but the word 'stopped' is on the top of the display. If I then press play again (while on the 'Now Playing' display--it doesn't work hitting play again while in 'Favorites') the station begins to play. View this thread: http://forums.slimdevices.com/showthread.php?t=23633
We should fix this immediately with the patch posted in bug 3384. Then use 3384 to fix the problem with the original code.
Created attachment 1229 [details] formal diff this is the workaround as a diff with changelog entry clearing THIS bug only. I guess 3384 would be left as the lower level problem of playlist add not working. Of course, with this patch, favorite->add as a function will still fail.
adding cc (odd that you can't add a cc at the same time as an attachment )
added to 6.3.0 at change 7330 added to trunk at change 7329 (along with some spacing fixes) downgrading severity, since the proposed short-term fix is in there. Not sure whether the right way to do this now is to close or merge with remaining issues from bug 3384.
The 5-8 build of 6.3.0 crash when I press favorites on the remote - 2006-05-08 09:06:43.2645 Backtrace: frame 0: Slim::Buttons::Common::pushMode (Slim/Buttons/Common.pm line 1139) frame 1: Slim::Buttons::Common::pushModeLeft (Slim/Buttons/Common.pm line 441 ) frame 2: Slim::Buttons::Common::__ANON__ (Slim/Hardware/IR.pm line 662) frame 3: Slim::Hardware::IR::executeButton (Slim/Control/Command.pm line 253) frame 4: Slim::Control::Command::execute (Slim/Player/Client.pm line 1002) frame 5: Slim::Player::Client::execute (Slim/Hardware/IR.pm line 675) frame 6: Slim::Hardware::IR::processCode (Slim/Hardware/IR.pm line 538) frame 7: Slim::Hardware::IR::releaseCode (Slim/Hardware/IR.pm line 431) frame 8: Slim::Hardware::IR::checkRelease (Slim/Utils/Timers.pm line 105) frame 9: Slim::Utils::Timers::checkTimers (C:\Program Files\SlimServer\server \slimserver.pl line 701) frame 10: main::idle (C:\Program Files\SlimServer\server\slimserver.pl line 6 32) frame 11: main::main (C:\Program Files\SlimServer\server\slimserver.pl line 1 265) 2006-05-08 09:06:43.3146 Crashing because 'PLUGIN.Favorites' has no mode functio n or a bogus function. Perhaps you mis-typed the mode name. Can't use string ("") as a subroutine ref while "strict refs" in use at Slim/But tons/Common.pm line 1082. 2006-05-08 09:06:43.5140 Shutting down plugins...
better as of 7339, but this code screams to be refactored. just plain ikky doing the same thing with two different meethods, especially within the same module :( sorry for break.
See if this works in 6.3, then set target to 6.5 for refactoring/cleanup
Verified fixed in SlimServer Version: 6.3.0 - 7895 - Windows XP - EN - cp1252
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.