Bugzilla – Bug 3351
Composers included in Artist count when browsing by Genre
Last modified: 2008-12-18 11:12:53 UTC
From the web interface, when going to Home / Browse Genres then selecting a particular Genre, under Home / Browse Genres / <genre> the interface provides information for that genre: "x" albums with "y" songs by "z" artists. The number of songs and albums appear to be correct, however the number of artists is incorrect for all but one genre in my collection. My music collection has 12 genres and for each of them. I checked the Slimserver Artist counts for each genre with the correct number of Artists: Genre - Correct number artists - Slim browser number of artists Alternative - 32 - 126 Blues - 2 - 7 Classical - 2- 5 Country - 4 - 17 Downtempo - 23 - 104 Electronica - 32 - 156 Folk - 17 - 70 Hip Hop - 1 - 1 House - 68 - 235 Pop - 8 - 47 Rock - 28 - 89 Trance - 23 - 38 I'm pretty sure the number of Composers is being included in the Artist count. Hip Hop, where the Slimserver artist count and actual artist count are correct, doesn't have any composers in any tracks in this genre. I also checked Blues and Classical and in each case, the Artist count provided by Slimserver was the number of Artists + the number of Composers within this Genre.
Needs to be fixed in new db.
This is fixed in 6.5
I've just upgraded from 6.3.1 to 6.5.1 - 10912 and this bug isn't doesn't appear to be completely fixed - under certain circumstances composer is still being included in artist counts when browsing and other counts are also wrong. e.g. if I browse by genre to "Home / Genres / Blues / Tom Waits" the browser says 13 albums with 197 songs by 7 artists The artist count is incorrect as it is counting the artist "Tom Waits" with 6 different composers included in the tags for these tracks. There appear to be other issues with album / artist / track counts. e.g. I only have 2 artists tagged under genre "Blues" "Home / Genres / Blues / Tom Waits" displays "13 albums with 197 songs by 7 artists" (number of artists incorrect as mentioned above) "Home / Genres / Blues / Nina Simone" displays "2 albums with 33 songs by 1 artist." (information correct) However: "Home / Genres / Blues" displays "17 albums with 233 songs by 2 artists." So an extra 2 albums and 3 tracks have appeared when browsing by genre compared to the sum of the individual counts when browsing by artist (although the artist count is correct) If I then list "All albums", "Home / Genres / Blues" displays "15 albums with 230 songs by 8 artists." so the album and track count is correct but the number of artists is wrong (composer is being included) In "Home / Server Settings / Behavior" none of the options in "COMPOSER, BAND AND ORCHESTRA IN ARTISTS" are selected.
Many of the displayed counts are off, even without composer tags. Apparently it's a very low or zero priority issue.
Created attachment 1733 [details] Test track 1 Test Track 1, Artist 1, Album 1, Composer 1, Test Genre
Created attachment 1734 [details] Test Track 2 Test Track 2, Artist 2, Album 2, Composer 2, Test Genre
As requested, sample tracks with tags to illustrate this problem. The tracks and tags are: Filename, Track, Album, Artist, Composer, Genre Track 1.mp3, Track 1, Album 1, Artist 1, Composer 1, Test Genre Track 2.mp3, Track 2, Album 2, Artist 2, Composer 2, Test Genre The various count results are: Home / Albums : 2 albums with 2 songs by 4 artists. (Incorrect) Home / Artists : 2 albums with 2 songs by 2 artists. (Correct) Home / Genres : 2 albums with 2 songs by 2 artists. (Correct) Home / Albums / Album 1 : 1 album with 1 song by 2 artists. (Incorrect) Home / Artists / Artist 1 : 1 album with 1 song by 2 artists. (Incorrect) Test tracks have been attached. I don't know if this covers all cases where the artist/album/track counts are incorrect, however if this is fixed, this should allow identification of other issues.
Wallace, after we have shipped 6.5.2, I would love for you to implement automated testing of this bug in the nightlies. The counts have always seemed very 'fragile' and prone to break as apparently-unrelated changes are made to the code.
Is this still an issue in SC7?
I don't know - I haven't tried 7 yet. I should get a chance in the next week or so.
This problem still exists in SC7 (SqueezeCenter_trunk_v2007-12-30)
To provide more information on this bug in Slimcenter 7, I compared the artist, album and song counts produced by Slimcenter (x albums with y songs by z artists) with the known correct counts in my library. 1. Browse by Artist Home > Artists Artist count: correct Album count: correct Song count: correct Home > Artists > [Artist name] Artist count: incorrect. I think both Artists and Composers are counted even though browsing by a particular artist should always have an artist count of 1. Album count: correct Song count: correct Home > Artists > [Artist name] > All songs Artist count: incorrect. I think both Artists and Composers are counted even though browsing by a particular artist should always have an artist count of 1. Album count: incorrect. When the Artist name also appears as the composer, it looks like the Album is double counted. Song count: incorrect. When the Artist name also appears as the composer, it looks like the Song is double counted. 2. Browse by Album Home > Albums Artist count: incorrect. I think both artists and composers are being counted. Album count: correct Song count: correct Home > Albums > [Album name] Artist count: incorrect. I think both artists and composers are being counted. Album count: correct Song count: correct 3. Browse by Genre Home > Genres Artist count: correct Album count: correct Song count: correct Home > Genres > [Genre name] Artist count: correct Album count: incorrect. I think album count is based upon artists and composers Song count: incorrect. I think sound count is based upon artists and composers Home > Genres > [Genre name] > All Albums Artist count: incorrect. I think artists and composers are being counted. Album count: correct. Song count: correct. Home > Genres > [Genre name] > All Albums > All Songs Artist count: incorrect. I think artists and composers are being counted. Album count: correct. Song count: correct.
On both tests tracks, SC 7.0 only shows one artist name for each track. However, the number of artist for each track says 2. Something is definitely wrong. Version of SC used is SqueezeCenter Version: 7.0 - 16286. Assigning this bug to Andy. If assigned wrong, please reassign.
Fixed in change 16614.
I've tested this fix in SqueezeCenter_7.0_v2008-01-25.dmg and came across one case where the Album and Track counts are not correct. In the browser interface, selecting: Home > Genres > [Genre name] The Album and Track counts are not correct, however selecting: Home > Genres > [Genre name] > All Albums The Album and Track counts are correct.
And another case that isn't correct. Home > Artists > [Artist name] Artist count, Album count and track count are correct. Home > Artists > [Artist name] > All Songs Artist count, Album count and track count are all incorrect.
Are you testing this with the 2 files from this bug, or other tracks?
(In reply to comment #17) > Are you testing this with the 2 files from this bug, or other tracks? > Sorry, I was testing this with my entire library which has got 10k tracks so it is possible that the cause of these different tracks counts is different from the other issues fixes in this bug that could be identified with the test tracks. I'll see if I can see what is causing the mismatches. The errors are consistent, however. The counts for Home > Genres > [Genre name] > All Albums agree with 3 other sources for this information (MusicIP, iTunes and a script I've written) for all the genres in my collection while the counts for Home > Genres > [Genre name] don't.
ok, I've done some more investigation and here is what I think is happening. I've uploaded 2 new test tracks. These are: Genre = Genre 1 Track Title = Track 1 Artist = Artist 1 Album = Album 1 Composer = Artist 2 Genre = Genre 2 Track Title = Track 2 Artist = Artist 2 Album = Album 2 Composer = Artist 1 Browsing to: Home > Genres > Genre 1 Shows 2 albums with 2 songs by 1 artist rather than 1 album with 1 song by 1 artist which is the correct answer. I think the count for albums and songs in Genre 1 is including albums and songs in Genre 2 because an artist in Genre 1 is a composer in a track in Genre 2. I tested this by removing the composer in Track 1 and it gave the correct answer. Also, Browsing to Home > Genres > Genre 1 > Artist 1 shows 1 album with 1 song by 1 artist. Browsing to Home > Genres > Genre 1 > Artist 1 > Album 1 shows 1 album with 1 song by 2 artists. The composer and artist are being included in the artist count
Created attachment 2730 [details] test track 1a
Created attachment 2731 [details] test track 2a
Created attachment 2732 [details] test track 2a
Created attachment 2733 [details] test track 1a
OK, I think I've fixed this in change 16781. Please re-test.
(In reply to comment #24) > OK, I think I've fixed this in change 16781. Please re-test. > Yes, everything seems to be ok now, thanks
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.