Bug 3330 – FLAC files with duplicate ReplayGain tags rejected

Bug 3330 - FLAC files with duplicate ReplayGain tags rejected

Summary:

FLAC files with duplicate ReplayGain tags rejected

Status:	RESOLVED WONTFIX

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Database
Version:	6.2.2
Platform:	PC Linux (other)

Importance:	P5 minor (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-04-26 18:44 UTC by David Myers
Modified:	2008-09-15 14:38 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Myers 2006-04-26 18:44:19 UTC

This is really minor, but I thought I'd report it anyway.  You'll probably want to close it with a status of "Go away kid, ya bother me."  :-)

In reviewing the log after installing the 6.2.2 release candidate of 4/25/06, I noticed errors like the following referring to only 3 out of ~7,300 FLAC files:

2006-04-26 20:31:34.4885 Couldn't create track for file:///net/calculon/music/flac/70s/do_you_feel_like_we_do.flac : Can't insert new Slim::DataStores::DBI::Track: Cannot call execute with a reference (ARRAY(0xb3260e4))
 at /usr/local/slimserver/Slim/DataStores/DBI/DBIStore.pm line 496

None of the 3 files for which these errors were logged ended up in the database.

Turns out that these 3 files each had 2 sets of ReplayGain tags.  I don't know how that happened, but it was easy to fix.

Comment 1 Dan Sully 2006-05-04 19:32:40 UTC

David - I'm going to do exactly that. While we could check every single possible tag if it's valid to have multiple values, something will always fall through the cracks. It's best to fix your tags.

Thanks