Bug 333 – MP3 frame detection needs to double check at the end of files.

Bug 333 - MP3 frame detection needs to double check at the end of files.

Summary:

MP3 frame detection needs to double check at the end of files.

Status:	RESOLVED WORKSFORME

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Formats
Version:	5.x or older
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	Future
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-06-03 08:44 UTC by Blackketter Dean
Modified:	2008-12-18 11:50 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2004-06-03 08:44:43 UTC

There's a todo in Slim::Formats::MP3 to look at the last two MP3 frames at the end of a MP3 file to 
ensure that we've found the last frame correctly.  Some tracks may (rarely) have bogus data at the end 
of a file that appears to be a valid MP3 frame, but it isn't.

Comment 1 Chris Owens 2007-07-10 12:48:23 UTC

Do you care to re-prioritize this bug, Dean?

Comment 2 Blackketter Dean 2007-07-23 07:20:14 UTC

I think that the latest frame scanning resolves this issues.

Comment 3 Chris Owens 2008-12-18 11:50:49 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.