Bugzilla – Bug 330
reloading Handheld skin can cause unexpected behavior
Last modified: 2008-12-18 11:55:25 UTC
I have not had a chance to reproduce these yet, but I have had customers report the following: - on the Status page, you can only click Next once, and pages after the first will not have that link. - when refreshing the status page, since it does not automatically refresh, the currently playing song may jump back to whatever was playing when that initial status page was generated. Reported on v5.1.5, one customer said he had problems with nightlies, of unknown date, and I have asked a couple of customers to try the latest (6/1/04) nightly.
I can't recreate the first problem, but I think I know what's going on with the second. The URL of the status page contains the command parameters that got us there (p0=playlist&p1=jump, for example). Refreshing the page reruns the command. Maybe the status page should do an immediate META HTTP refresh to a version without the command parameters?
Ok, this first problem doesn't seem to happen any more. I reproduced both of them but hadn't had a chance to update the bug... The skipping a track thing when refreshing the page is pretty annoying though.
having the whole page inside a dummy frameset would solve this problem. Do any handheld browsers have a problem with frames??
Created attachment 261 [details] place handheld skin inside a frame This relieves the skin of the stated problems. Where HandHeld skin is most used, do those browsers have issues with frames??
Handheld skin is often used in browsers without frames. A simpler solution would be to put a refresh button in the page itself. (and have the auto-refresh load the base URL without the command parameters.) Vidur says that it's not being automatically reloaded. Vidur?
A refresh button on the page would IMHO be the same as the Status link in the top menu - that's what I'm using to refresh the display. And no, there's no automatic refresh.
Michael: how hard would it be to add an auto referesh of the status page that would reload without the parameters?
Created attachment 445 [details] Refresh status automatically Before I commit that patch I wanted to ask whether we should have some kind of a redirect/refresh standard: status_header.html uses only a variable "refresh", the url is hardcoded. I had to add the refresh to the pageheader.html - where I don't want an url for only one page. Now I'm using a second variable for the url in pageheader.html, which I have to create in status_header.html. If we had a redirect hash (containing delay and url) in the params hash we could add the (conditional) redirect directive to any pageheader.html - would come in handy for my biography plugin, too ;-)
If this patch fixes the bug, then go ahead and commit it. Feel free to submit another patch that cleans up the implementation.
I checked in change 3090 a few weeks back. IMHO this case can be closed.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!
Routine bug db maintenance; removing old versions which cause confusion. I apologize for the inconvenience.