Bug 3294 - Search, Random Albums, group by Artist - multiple albums with same name
: Search, Random Albums, group by Artist - multiple albums with same name
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.5b1
: PC Debian Linux
: P1 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-19 03:03 UTC by Thomas Engelschmidt
Modified: 2008-09-15 14:39 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Engelschmidt 2006-04-19 03:03:25 UTC
When choosing random albums - the random plugin selecting is based only album name. If the music library contains several albums with identical names, the playlist will mixes several differents albums together.

This 'feature' is also present when searching for an album - and clicks the found album links (The Masters) 

Solution: add group by artist to the sql statement for selecting songs based upon album name criteria.

for example : 

1. Pumpin' For Jill from The Masters by Iggy Pop
1. What A Little Moonlight Can Do from The Masters by Billie Holiday
2. Billie's Blues from The Masters by Billie Holiday
2. Loco Mosquito from The Masters by Iggy Pop
3. Dog Food from The Masters by Iggy Pop
3. Let's Call The Whole Thing Off from The Masters by Billie Holiday
4. New Values from The Masters by Iggy Pop
4. Strange Fruit from The Masters by Billie Holiday
..
...
Comment 1 KDF 2006-04-19 09:05:19 UTC
Have you tried adding "the masters" to the 'common album titles' pref, server settigns->bahaviour?
Comment 2 Thomas Engelschmidt 2006-04-19 09:32:52 UTC
(In reply to comment #1)
> Have you tried adding "the masters" to the 'common album titles' pref, server
> settigns->bahaviour?

Thanks for your suggestion. It didn't change how the selected songs were group together. 

Tested the suggestion from the search function, since my music collection is rather large, it would be nearly impossible to randomly hit the 2 albums today :-) - I will clear the db later this week, and try with only minimal number of albums.

But since I would assume that selecting sql statement used for selection the titles in a random album is the same as or at  least very similar to the Search statement. The 'common album titles'  fix should also work here.. 
Comment 3 KDF 2006-04-19 10:02:36 UTC
use d_sql if you want to see the queries.  you may need a full rescan for the effects of the common album titles to take effect.  
Comment 4 Dan Sully 2006-04-22 15:25:23 UTC
Thomas - I'd love to see the --d_sql output of this after you've done a Wipe & Rescan.

Thanks.
Comment 5 Thomas Engelschmidt 2006-04-29 12:22:18 UTC
Hi Dan, 

I have created the sql output using the following procedure : 

1) Creating a new music lib with the following albums   
  Billie Holiday - Me myself and I
  Billie Holiday - The Masters
  Erik Hillestad - Lullabies from the Axis of Evil
  Iggy Pop - American Caesar
  Iggy Pop - Pop Songs
  Iggy Pop - The Masters

2) wipe log and Restart Slimserver

3) Wipe and rescan 

4) Enable d_sql debugging

Running the latest nightly build debian on a mysql backend. it was not possible to reproduce the 'bug' either from the Random Album Mix or from the server - Its works like a charm :-) 

The only comment I have is concerning the search output - since the 'the masters' albums have identical names, it would be very nifty if the artists name were also shown. 

Artists matching "the masters": 0

Albums matching "the masters": 2

The Masters Play Add to playlist
The Masters Play Add to playlist

Song titles matching "the masters": 0

In the future, I will try to respond faster to your request - 

Thanks

Thomas