Bugzilla – Bug 3276
removing artist from playlist by clicking X removes entire playlist
Last modified: 2011-03-16 04:35:06 UTC
Using the fishbone skin with the 4/15 daily on 6.5b1. Clicking on X under "now playing" removes the entire playlist, not just the artist that is currently playing.
it seems that the url for the deletealbum is no longer working. fred? any suggestions? status_header.html?p0=playlist&p1=deletealbum&p4=test seems to lead to deletetracks, with no params. and a dumper in playlistXalbumCommand shows that the function is never called, despite being set as the request handler for deletealbum.
Nothing wrong with the plumbing, just an unexpected case. You must provide all the values, in this case p2 and p3. The parsing code stops at the first undefined value in the array. We really need to fix the command stuff in the URLs...
I can add the missing parms, but if you think the the proper fix is to handle missing ones (?) I can wait?
For the moment process URL does a command/subcommand structure as well as maintain the pX. Both are handled by Request. Not sure what the proper fix is given the legacy. But I'd like to avoid supporting the half baked case we're discussing. Parameters are named in URL so if some parameters are "undef", just don't add them. But mapping this on a structure designed to count them as if aligned in an array (the pX), does not seem right to me. I will have a deeper look at ProcessURL.
fixed in trunk at change 6961. thanks for the notes, Fred.