Bug 3254 - Common album titles with group multi-disc albums as single doesn't work
: Common album titles with group multi-disc albums as single doesn't work
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.2.2
: All All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-08 18:01 UTC by Daniel Born
Modified: 2008-09-15 14:38 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
zip containing 3 albums and 1 screenshot (2.49 MB, application/x-zip-compressed)
2006-06-21 15:53 UTC, Ross Levine
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Born 2006-04-08 18:01:14 UTC
Using V6.2.2 nightly from 2006-04-07

-I have 3 discs named "Live" by "AC/DC".
-The album name "Live" is in the Common Album Titles list.
-One album doesn't have the "discnumber" tag and is stored in folder \ACDC - Live\
-The other double-disc album has the first disc stored in \ACDC - Live (disc 1 of 2)\ and has the discnumber tag set to "1/2". The second disc is stored in \ACDC - Live (disc 2 of 2)\ and has the discnumber tag set to "2/2".

-The Group Discs option is set to "Treat multi-disc sets as a single album".

I would expect to see two albums "Live" by "AC/DC". One with the 1 disc album and the other with the two disc album combined as one.

I am seeing three albums (the Group Discs setting is not being used for titles found in the Common Album Titles.
Comment 1 Dan Sully 2006-04-25 14:31:58 UTC
Love that corner case.
Comment 2 Dan Sully 2006-04-26 15:23:50 UTC
Fixed in change 7151
Comment 3 Ross Levine 2006-06-19 18:52:16 UTC
Daniel,

I'm trying to reproduce this on our end here; what tag editor are you using? I've looked in both 
audacity as well as winamp, no sign of 'discnumber'. 
Comment 4 Daniel Born 2006-06-20 04:33:02 UTC
I'm using Mp3tag and the tag is TPOS (aka discnumber in Mp3tag).
Comment 5 Ross Levine 2006-06-20 14:39:22 UTC
(In reply to comment #4)
> I'm using Mp3tag and the tag is TPOS (aka discnumber in Mp3tag).
> 

I've downloaded and installed MP3tag. When I load up a directory of the music files I've created (or for that matter any file) I'm given the option to edit these tags: title, artist, album, year, track, genre, and comment. 

I'm still not seeing discnumber. Is this a field you created? 
Comment 6 Daniel Born 2006-06-21 07:51:02 UTC
No, this is a tag part of the id2v3/v4 standard. See this file in your setup:
C:\Program Files\Mp3tag\help\main_tags.html

See here also: http://www.id3.org/id3v2.3.0.html#TPOS

In Mp3tag, you can add your own tags to view:
View->Customize Columns
Click on "New Configuration" button and then enter this info:
Name: discnumber
Value: %discnumber%
Field: %discnumber%
and then click on "Ok". 

This should do it. The data is stored in the TPOS field.
Comment 7 Ross Levine 2006-06-21 15:52:36 UTC
Daniel, Thanks for the ID3 tag education. 

Looks like we can't quite verify this bug as fixed just yet, something is still not quite right. When 'grouping' as single-album, sure enough they do show up as a single album. However when grouping as multiple albums, they don't show up properly. 

I've loaded 3 albums, trying to reproduce Daniel's situation as accurately as possible. All 3 albums have the same Album tag 'Live'. One album does NOT have a 'discnumber' (TPOS) tag, one album has '1/2' for discnumber tag, and the final album has '2/2' for discnumber. I'm attaching a zip file containing these 3 created albums, as well as a screenshot which specifically shows the current issue. 

When grouping as multiple albums, we should see this:

Live [the album with null discnumber]
Live (disc 1/2)
Live (disc 2/2)

Instead what we're seeing is:

Live
Live (disc 2/2)

FYI, disc 1/2 is for whatever reason being dumped under Live.

SlimServer Version: 6.3.0 - 7987 - Windows XP - EN - cp1252

-Rookie bug tester
Comment 8 Ross Levine 2006-06-21 15:53:44 UTC
Created attachment 1279 [details]
zip containing 3 albums and 1 screenshot
Comment 9 Dan Sully 2006-06-22 09:14:47 UTC
Fixed in change 8102
Comment 10 Ross Levine 2006-06-22 13:26:34 UTC
Attempted to verify in latest nightly, issue is still present. Please comment again when there is an available build of slim server for me to verify.

SlimServer Version: 6.3.0 - 8099 - Windows XP - EN - cp1252
Comment 11 Dan Sully 2006-06-22 13:29:44 UTC
The change will be in tonight's build, since it was fixed this morning. Alternatively, if you are running svn, update that.
Comment 12 Ross Levine 2006-06-26 16:41:57 UTC
SlimServer Version: 6.3.0 - 8132 - Windows XP - EN - cp1252

Verified as fixed, works beautifully. 

Thanks Dan. 
Comment 13 Chris Owens 2006-06-27 14:21:45 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.